feat: add and remove products to/from collection in bulk endpoints #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eProducts on collections that uses these bulk operations
srindom
requested changes
Feb 9, 2022
packages/medusa/src/api/routes/admin/collections/update-products.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/collections/update-products.ts
Outdated
Show resolved
Hide resolved
srindom
requested changes
Feb 14, 2022
packages/medusa/src/api/routes/admin/collections/update-products.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/collections/update-products.ts
Outdated
Show resolved
Hide resolved
| ): Promise<Product[]> { | ||
| await this.createQueryBuilder() | ||
| .update(Product) | ||
| .set({ collection_id: undefined }) |
There was a problem hiding this comment.
Wouldn't it be more correct to do collection_id: null?
There was a problem hiding this comment.
TS will complain that collection_id can only be off type string or undefined. Alternativly I could change .update(Product) to .update("product") to avoid using the TS type and thereby avoid the warning.
There was a problem hiding this comment.
Ahh makes sense - I think we then have to make sure that the type of collection_id becomes string | null.
Generally, if we have @Column({ nullable: true }) in a model we need to allow null as a type on that column; we haven't done this previously as we weren't using TS so completely fine to add that :)
srindom
requested changes
Feb 15, 2022
packages/medusa/src/api/routes/admin/collections/add-products.ts
Outdated
Show resolved
Hide resolved
kasperkristensen
changed the title
srindom
approved these changes
Feb 16, 2022
adrien2p
pushed a commit
to adrien2p/medusa
that referenced
this pull request
Feb 23, 2022
…edusajs#1032) * adds bulk add/remove products to/from collection. Adds endpoint updateProducts on collections that uses these bulk operations * fix integration tests and test description * undo change to swap * made requested changes * added removeProducts endpoint * made requested changes * fix: set collection_id null * updated collection_id to type string | undefined
olivermrbl
pushed a commit
that referenced
this pull request
Feb 25, 2022
…1032) * adds bulk add/remove products to/from collection. Adds endpoint updateProducts on collections that uses these bulk operations * fix integration tests and test description * undo change to swap * made requested changes * added removeProducts endpoint * made requested changes * fix: set collection_id null * updated collection_id to type string | undefined
SGFGOV
pushed a commit
to SGFGOV/medusa
that referenced
this pull request
Apr 19, 2022
…edusajs#1032) * adds bulk add/remove products to/from collection. Adds endpoint updateProducts on collections that uses these bulk operations * fix integration tests and test description * undo change to swap * made requested changes * added removeProducts endpoint * made requested changes * fix: set collection_id null * updated collection_id to type string | undefined
SGFGOV
pushed a commit
to SGFGOV/medusa
that referenced
this pull request
Apr 19, 2022
…edusajs#1032) * adds bulk add/remove products to/from collection. Adds endpoint updateProducts on collections that uses these bulk operations * fix integration tests and test description * undo change to swap * made requested changes * added removeProducts endpoint * made requested changes * fix: set collection_id null * updated collection_id to type string | undefined
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
POST admin/collections/<id>/products/batch, that allows users to add products associated with the given Product Collection in bulk.DELETE admin/collections/<id>/products/batch, that allows users to remove products associated with the given Product Collection in bulk.Why
How
addProductsandremoveProductsmethods in the ProductCollectionService.Testing