Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): variant creation with prices in productservice.create #5410

Merged
merged 40 commits into from
Oct 30, 2023

Conversation

pKorsholm
Copy link
Contributor

What

  • ensure variants are created with prices when included in create-product request body

closes #5306

@pKorsholm pKorsholm requested a review from a team as a code owner October 18, 2023 15:39
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: 5c5790e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:17am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:17am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 10:17am

@olivermrbl
Copy link
Contributor

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin@7.1.5-snapshot-20231018180119
yarn add @medusajs/admin-ui@2.1.5-snapshot-20231018180119
yarn add create-medusa-app@1.2.3-snapshot-20231018180119
yarn add @medusajs/inventory@1.11.1-snapshot-20231018180119
yarn add @medusajs/link-modules@0.2.1-snapshot-20231018180119
yarn add @medusajs/medusa@1.17.2-snapshot-20231018180119
yarn add medusa-file-s3@1.4.0-snapshot-20231018180119
yarn add @medusajs/medusa-js@6.1.2-snapshot-20231018180119
yarn add medusa-plugin-brightpearl@1.3.12-snapshot-20231018180119
yarn add @medusajs/modules-sdk@1.12.1-snapshot-20231018180119
yarn add @medusajs/medusa-oas-cli@0.2.22-snapshot-20231018180119
yarn add @medusajs/orchestration@0.4.2-snapshot-20231018180119
yarn add @medusajs/pricing@0.1.1-snapshot-20231018180119
yarn add @medusajs/product@0.3.1-snapshot-20231018180119
yarn add @medusajs/types@1.11.4-snapshot-20231018180119
yarn add @medusajs/utils@1.10.4-snapshot-20231018180119
yarn add @medusajs/workflows@0.2.4-snapshot-20231018180119

Latest commit: a27083c

@olivermrbl
Copy link
Contributor

/snapshot-this

@@ -0,0 +1,147 @@
import path from "path"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment(this-file): Something is off about having integration tests for core services in the plugins directory. I think we should move this to API (even though not ideal either) to have it closer to the core. Wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, however there's something about having the redis_url in the project config of the api that breaks the bootstrapApp({ cwd }) method for server setup, though it's needed to get the container

@olivermrbl olivermrbl merged commit 4d52082 into develop Oct 30, 2023
15 checks passed
@olivermrbl olivermrbl deleted the fix/variant-creation-in-create-product branch October 30, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues creating a new product with a variant with money amount
2 participants