Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): sendgrid plugin typescript rewrite #5984

Closed

Conversation

luluhoc
Copy link
Contributor

@luluhoc luluhoc commented Jan 2, 2024

rewrite SendGrid plugin to typescript; bump SendGrid dep and rewrite to new medusa API

adds some functionality also as custom subject to orders

and some docs corrections order_shipped_template should be order_shipment_created_template

it has breaking changes in the plugin configuration i updated the docs too

@luluhoc luluhoc requested review from a team as code owners January 2, 2024 13:57
Copy link

changeset-bot bot commented Jan 2, 2024

⚠️ No Changeset found

Latest commit: b01878a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 2, 2024

Someone is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@luluhoc luluhoc changed the title Feat(): sendgrid plugin typescript Feat(): sendgrid plugin typescript rewrite Jan 2, 2024
@luluhoc
Copy link
Contributor Author

luluhoc commented Jan 2, 2024

@luluhoc luluhoc changed the title Feat(): sendgrid plugin typescript rewrite feat(): sendgrid plugin typescript rewrite Jan 2, 2024
@adrien2p
Copy link
Member

adrien2p commented Jan 3, 2024

@luluhoc we will have a review as soon as we can, but don't change the version of the package manually. It is done automatically by the changeset later

@luluhoc
Copy link
Contributor Author

luluhoc commented Jan 3, 2024

@luluhoc we will have a review as soon as we can, but don't change the version of the package manually. It is done automatically by the changeset later

@adrien2p ok, thanks. I reverted the package version to the original

@luluhoc
Copy link
Contributor Author

luluhoc commented Jan 28, 2024

@luluhoc luluhoc requested a review from a team as a code owner February 17, 2024 13:42
@luluhoc
Copy link
Contributor Author

luluhoc commented Feb 17, 2024

any news?

@luluhoc
Copy link
Contributor Author

luluhoc commented Feb 28, 2024

There is also a major error in docs after the recent push order_shipped_template should be order_shipment_created_template

I already tested it in my production

@kasperkristensen @pKorsholm @riqwan @olivermrbl @adrien2p

@luluhoc
Copy link
Contributor Author

luluhoc commented Apr 29, 2024

bump

@adrien2p
Copy link
Member

Sorry for the lack of response, we are currently focused on medusa 2.0 but we will get back to you 👍

@sradevski
Copy link
Member

Hey @luluhoc , as the architecture of how notifications in v2 changed significantly, We will close this PR. Thanks for the contribution though, I hope at the very least helped you got a better understanding of Medusa, and we'll be looking forward to your contributions again!

@sradevski sradevski closed this May 15, 2024
@luluhoc
Copy link
Contributor Author

luluhoc commented May 15, 2024

@sradevski Hey, I understand that it may not be suitable for v2, although it fixes some problems with the plugin in 1.x so it still could have been merged to 1.x train.

@sradevski
Copy link
Member

@luluhoc if there is a bug that needs fixing, let's have a PR just for that fix. Converting to TS shouldn't be a requirement to do that, as it makes it much more time-consuming for us to review it, without a long-term benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants