New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): sendgrid plugin typescript rewrite #5984
feat(): sendgrid plugin typescript rewrite #5984
Conversation
|
Someone is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
@luluhoc we will have a review as soon as we can, but don't change the version of the package manually. It is done automatically by the changeset later |
any news? @kasperkristensen @pKorsholm @riqwan @olivermrbl @adrien2p |
any news? |
There is also a major error in docs after the recent push I already tested it in my production |
bump |
Sorry for the lack of response, we are currently focused on medusa 2.0 but we will get back to you 👍 |
Hey @luluhoc , as the architecture of how notifications in v2 changed significantly, We will close this PR. Thanks for the contribution though, I hope at the very least helped you got a better understanding of Medusa, and we'll be looking forward to your contributions again! |
@sradevski Hey, I understand that it may not be suitable for v2, although it fixes some problems with the plugin in 1.x so it still could have been merged to 1.x train. |
@luluhoc if there is a bug that needs fixing, let's have a PR just for that fix. Converting to TS shouldn't be a requirement to do that, as it makes it much more time-consuming for us to review it, without a long-term benefit. |
rewrite SendGrid plugin to typescript; bump SendGrid dep and rewrite to new medusa API
adds some functionality also as custom subject to orders
and some docs corrections
order_shipped_template
should beorder_shipment_created_template
it has breaking changes in the plugin configuration i updated the docs too