Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart): Add line items in cart-creation #6114

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@olivermrbl olivermrbl requested review from a team as code owners January 17, 2024 13:46
Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: 011a978

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 0:37am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 0:37am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 0:37am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 0:37am

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of non blocking suggestions, lgtm!

packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
@riqwan
Copy link
Contributor

riqwan commented Jan 18, 2024

Also, missing changeset for types

@olivermrbl olivermrbl merged commit b132ff7 into develop Jan 18, 2024
16 checks passed
@olivermrbl olivermrbl deleted the feat/cm-line-items-to-cart branch January 18, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants