Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payment): PaymentCollection CRUD #6124

Merged
merged 19 commits into from
Jan 22, 2024
Merged

feat(payment): PaymentCollection CRUD #6124

merged 19 commits into from
Jan 22, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jan 18, 2024 •
edited
Loading

What

  • PaymentCollection service CRUD

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3d99c94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 8:47am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 22, 2024 8:47am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 8:47am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 8:47am

@fPolic
Merge branch 'develop' into feat/payment-module-payment-collection-crud
7c90f75 
# Conflicts:
#	packages/types/src/payment/mutations.ts
@fPolic fPolic changed the base branch from feat/payment-module-interfaces to develop January 18, 2024 16:19
@fPolic fPolic marked this pull request as ready for review January 18, 2024 16:21
@fPolic fPolic requested review from a team as code owners January 18, 2024 16:21
olivermrbl
olivermrbl requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work – couple of todos, mainly related to our new approach to repositories

packages/payment/src/repositories/payment-collection.ts Outdated Show resolved Hide resolved
packages/payment/src/loaders/container.ts Outdated Show resolved Hide resolved
packages/payment/src/services/payment-module.ts Outdated Show resolved Hide resolved
packages/payment/src/services/payment-module.ts Outdated Show resolved Hide resolved
packages/payment/src/services/payment-module.ts Outdated Show resolved Hide resolved
packages/payment/src/services/payment-module.ts Outdated Show resolved Hide resolved
packages/payment/src/services/payment-module.ts Outdated Show resolved Hide resolved
olivermrbl
olivermrbl requested changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – a couple of minor todos

packages/payment/src/services/index.ts Outdated Show resolved Hide resolved
packages/payment/src/services/payment-module.ts Outdated Show resolved Hide resolved
packages/payment/src/services/payment-module.ts Outdated Show resolved Hide resolved
packages/payment/src/services/payment-module.ts Show resolved Hide resolved
@fPolic
Merge branch 'develop' into feat/payment-module-payment-collection-crud
2250b24 
# Conflicts:
#	packages/payment/src/loaders/container.ts
@olivermrbl olivermrbl merged commit d47e946 into develop Jan 22, 2024
16 checks passed
@olivermrbl olivermrbl deleted the feat/payment-module-payment-collection-crud branch January 22, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p left review comments

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fPolic @adrien2p @olivermrbl