Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customer module skeleton #6126

Merged
merged 18 commits into from
Jan 19, 2024
Merged

feat: customer module skeleton #6126

merged 18 commits into from
Jan 19, 2024

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Jan 18, 2024

No description provided.

@srindom srindom requested review from a team as code owners January 18, 2024 12:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f932a50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 5:56pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 18, 2024 5:56pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 5:56pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 5:56pm

adrien2p
adrien2p requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🔥

packages/customer/package.json Outdated Show resolved Hide resolved
packages/customer/src/index.ts Show resolved Hide resolved
packages/customer/src/models/address.ts Outdated Show resolved Hide resolved
packages/customer/src/models/customer-group-customer.ts Outdated Show resolved Hide resolved
packages/customer/src/models/address.ts Show resolved Hide resolved
packages/customer/src/services/customer-group.ts Outdated Show resolved Hide resolved
packages/customer/src/services/customer-module.ts Show resolved Hide resolved
packages/customer/src/services/customer.ts Outdated Show resolved Hide resolved
packages/types/src/customer/common.ts Show resolved Hide resolved
packages/types/src/customer/service.ts Show resolved Hide resolved
@adrien2p
Copy link
Member

heuuu, I am very sorry @srindom , I thought it was ready to review when i received the email and seen it open 😂

@srindom
Copy link
Collaborator Author

srindom commented Jan 18, 2024

@adrien2p - please take another look when you have time

@srindom srindom requested a review from adrien2p January 18, 2024 17:57
adrien2p
adrien2p approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 couple of todo's that ca also be done later

packages/customer/src/models/customer.ts
})
updated_at: Date

@Property({ columnType: "timestamptz", nullable: true })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: missing index

packages/customer/src/types/address.ts
metadata?: Record<string, unknown> | null
}

export type UpdateAddressDTO = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: missing id I think

packages/customer/src/types/address.ts
@@ -0,0 +1,28 @@
export type CreateAddressDTO = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: change type to interfaces as per our discussion

packages/customer/src/types/customer-group.ts
metadata?: Record<string, unknown> | null
}

export type UpdateCustomerGroupDTO = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: move from type to interface, then we could have something like

export interface UpdateCustomerGroupDTO extends Partial<CreateCustomerGroupDTO> {
  id: string
}

packages/types/src/customer/mutations.ts
metadata?: Record<string, unknown>
}

export interface UpdateCustomerDTO {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export interface UpdateCustomerDTO {
export interface UpdateCustomerDTO extends CreateCustomerDTO {
id: string
}

@kodiakhq kodiakhq bot merged commit 12aa173 into develop Jan 19, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the feat/customer-module branch January 19, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl left review comments

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srindom @adrien2p @olivermrbl