Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Pub Api Key domain #6162

Merged
merged 14 commits into from
Jan 23, 2024
Merged

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Jan 22, 2024

What

  • Adds Pub. Api Key domain

Note

  • Pagination for sales channels associated with the pubkey is not implemented correctly as it is not supported by the API. Will open a separate issue on this, and revisit the impl. once fixed.

CLOSES CORE-1656

@kasperkristensen kasperkristensen requested review from a team as code owners January 22, 2024 14:27
Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: 5a5171c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 8:05pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 23, 2024 8:05pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 8:05pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 8:05pm

@olivermrbl
Copy link
Contributor

The modal does not close on submit:

CleanShot.2024-01-22.at.19.18.58.mp4

I rebuilt the dashboard project and tested again. Same result. Let me know if there is anything else I need to clear before trying again, if the issue is not present on your side.

@olivermrbl
Copy link
Contributor

Any particular reason for having a link to the user here:

CleanShot 2024-01-22 at 19 59 19

To me it is a pretty uncommon use case to wanting to navigate from pub key -> user. If you agree, we could kill it

@olivermrbl
Copy link
Contributor

nitpicking(non-blocking): Should we remove "Revoke" when key is revoked?

CleanShot 2024-01-22 at 20 00 55

@olivermrbl
Copy link
Contributor

suggestion(non-blocking): Include "Created" in the details overview. If you have multiple active keys and you can't differentiate, the "Created" usually helps to give an indication of what is used and what is not. Ideally, we'd have a "Last used".

CleanShot 2024-01-22 at 20 02 25

@olivermrbl
Copy link
Contributor

Overall really nice @kasperkristensen. Left a couple of comments and suggestions 💪

@kasperkristensen
Copy link
Contributor Author

@olivermrbl Thanks I'll address the issues later today.

Re: Having the link to the user, I added that from the perspective that users should be able to navigate between related pages with ease. Just like how in Linear if I go to an issue you've created, then I can click on your avatar and go to a page with all your issues. So I'd like to keep the functionality, but I agree it seems a bit out of place as it currently is, I'll try something else.

Re: Having a Created field in the details, Ludvig is currently experimenting with how we can display created_at and updated_at on all pages in a nice uniform matter, so I'll add that here as well once we land on a pattern 😄

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@kodiakhq kodiakhq bot merged commit c37c82c into develop Jan 23, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the feat/3.0-pub-api-key-management branch January 23, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants