Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pricing models uses standardized relationships attributes #6767

Merged
merged 5 commits into from Mar 21, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Mar 21, 2024

what:

  • all relationships under all models are standardized

Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: a4ae5c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review March 21, 2024 08:15
@riqwan riqwan requested a review from a team as a code owner March 21, 2024 08:15
Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 9:29am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 21, 2024 9:29am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 9:29am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 9:29am

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice clean up!

@olivermrbl
Copy link
Contributor

Although, it seems we still have some cleaning to do in the tests

@riqwan
Copy link
Contributor Author

riqwan commented Mar 21, 2024

@olivermrbl which one are you referring to? I can add it to the list. I plan to nuke a chunk of the module's integration tests

@olivermrbl
Copy link
Contributor

@riqwan, no specific tests, I just noticed the modules pipeline was failing :)

@kodiakhq kodiakhq bot merged commit cf8b5ce into develop Mar 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants