feat(utils): custom serialization that allows for non self ref #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6bb7947 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
sradevski
reviewed
Mar 27, 2024
…dusa into feat/mikro-orm-serialization
sradevski
reviewed
Mar 27, 2024
packages/utils/src/dal/mikro-orm/__tests__/mikro-orm-serializer.spec.ts
Outdated
Show resolved
Hide resolved
sradevski
approved these changes
Mar 27, 2024
|
@olivermrbl can I merge this one? |
olivermrbl
approved these changes
Mar 27, 2024
Merged
This was referenced Mar 28, 2024
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow to specify a new option for the serialize utils which is
preventCircularRef, by default this options is set to true and you have to opt out if you want. The result of the serialized data will be the following:instead of
I suggest that we live with it and if everything is fine, and we are ready to upgrade, I can open a pr on mikro repo