Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pricing update and refactor product API tests to not rely on internals #6892

Merged
merged 1 commit into from
Apr 1, 2024
Merged

feat: Pricing update and refactor product API tests to not rely on internals #6892

merged 1 commit into from
Apr 1, 2024

Conversation

sradevski
Copy link
Member

@sradevski sradevski commented Apr 1, 2024 •
edited

This PR achieves the following

  • Remove dependency on internals for seeding the tests (more work left, but major work done)
  • Adds the workflow for updating variant's price

I will do a follow-up PR to further clean up the tests and remove all internal dependencies

@sradevski sradevski requested a review from a team as a code owner April 1, 2024 07:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2024 •
edited

⚠️ No Changeset found

Latest commit: 3577d2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 9:20am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 1, 2024 9:20am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 9:20am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 9:20am

olivermrbl
olivermrbl approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicr work – overall LGTM

packages/core-flows/src/product/steps/get-variant-pricing-link.ts Outdated Show resolved Hide resolved
packages/core-flows/src/product/workflows/update-product-variants.ts
Comment on lines +81 to +87
const linkForVariant = data.variantPriceSetLinks.find(
(link) => link.variant_id === variant.id
)

const priceSetForVariant = data.updatedPriceSets.find(
(priceSet) => priceSet.id === linkForVariant?.price_set_id
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: convert to maps, this is one of those potentially heavy operations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivermrbl I'd like to do some benchmarking and optimization as a separate task if you agree (I'm taking notes on this)

@sradevski sradevski force-pushed the product-module-unified-tests branch from bd6b9bb to 2779055 Compare April 1, 2024 09:14
@sradevski sradevski force-pushed the product-module-unified-tests branch from 2779055 to 3577d2e Compare April 1, 2024 09:18
@kodiakhq kodiakhq bot merged commit 585818e into develop Apr 1, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the product-module-unified-tests branch April 1, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sradevski @olivermrbl