Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete shipping options #6993

Merged
merged 20 commits into from
Apr 9, 2024
Merged

feat: delete shipping options #6993

merged 20 commits into from
Apr 9, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Apr 7, 2024 •
edited

What

  • delete shipping options workflow
  • delete shipping options api end point and validation
  • delete shipping options all integration tests
  • list shipping optionsAPI

FIXES CORE-1927
FIXES CORE-1953

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2024 •
edited

⚠️ No Changeset found

Latest commit: 0bd8e73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p changed the title Feat/delete shipping options Feat(): delete shipping options Apr 7, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 0:07am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 9, 2024 0:07am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 0:07am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 0:07am

@adrien2p adrien2p marked this pull request as ready for review April 7, 2024 14:44
@adrien2p adrien2p requested a review from a team as a code owner April 7, 2024 14:44
@adrien2p adrien2p requested review from sradevski, fPolic and pKorsholm and removed request for a team April 7, 2024 14:44
@adrien2p adrien2p changed the base branch from feat/shipping-options-updatre to develop April 8, 2024 06:55
@adrien2p adrien2p force-pushed the feat/delete-shipping-options branch from d2c4035 to 1c795f5 Compare April 8, 2024 06:55
olivermrbl
olivermrbl approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@adrien2p
Copy link
Member Author

adrien2p commented Apr 9, 2024

@olivermrbl when this is green could I merge?

@olivermrbl
Copy link
Contributor

Yes, for sure

@olivermrbl olivermrbl changed the title Feat(): delete shipping options feat: delete shipping options Apr 9, 2024
@olivermrbl olivermrbl merged commit e1a0960 into develop Apr 9, 2024
24 checks passed
@olivermrbl olivermrbl deleted the feat/delete-shipping-options branch April 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues left review comments

@sradevski sradevski sradevski approved these changes

@fPolic fPolic fPolic approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@pKorsholm pKorsholm Awaiting requested review from pKorsholm pKorsholm is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adrien2p @olivermrbl @sradevski @fPolic @carlos-r-l-rodrigues