Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create product category flow #7034

Merged
merged 4 commits into from
Apr 15, 2024
Merged

feat: Create product category flow #7034

merged 4 commits into from
Apr 15, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Apr 9, 2024 •
edited

What

  • Add create product category flow
  • Convert API integration test suite to V2 test runner

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2024 •
edited

⚠️ No Changeset found

Latest commit: 83f5b19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 9, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 11:55am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 15, 2024 11:55am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 11:55am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 11:55am

@olivermrbl olivermrbl marked this pull request as ready for review April 15, 2024 09:05
@olivermrbl olivermrbl requested a review from a team as a code owner April 15, 2024 09:05
sradevski
sradevski approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I didn't review the tests since the diff is impossible :)

packages/core-flows/src/product-category/steps/create-product-category.ts
import { StepResponse, createStep } from "@medusajs/workflows-sdk"

type CreateProductCategoryStepInput = {
product_category: CreateProductCategoryDTO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically we accept an array for the input, should we do the same here? Or is there a reason we can't?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product category service + repository will need a makeover to allow for bulk operations. This is a pretty comprehensive change, so I decided to open this PR now and then we can address the bulk support in a follow-up PR.

packages/medusa/src/api-v2/admin/product-categories/query-config.ts Outdated Show resolved Hide resolved
packages/medusa/src/api-v2/admin/product-categories/route.ts Outdated Show resolved Hide resolved
@olivermrbl
Copy link
Contributor Author

but I didn't review the tests since the diff is impossible

Yeah, I am not sure we can do it any differently when converting the test suites. As long as the V1 tests are still passing without any changes, I think we should be fine.

@olivermrbl olivermrbl merged commit bc081a7 into develop Apr 15, 2024
24 checks passed
@olivermrbl olivermrbl deleted the feat/product-categories branch April 15, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@pKorsholm pKorsholm Awaiting requested review from pKorsholm pKorsholm is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olivermrbl @sradevski