chore(dashboard): Cleanup Pricing domain #7035
Conversation
kasperkristensen
requested review from
sradevski,
carlos-r-l-rodrigues and
olivermrbl
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
| if (isError) { | ||
| throw error | ||
| } | ||
|
|
||
| return ( | ||
| <div className="flex flex-col gap-y-2"> | ||
| <ApiKeyGeneralSection apiKey={api_key} /> | ||
| <ApiKeySalesChannelSection apiKey={api_key} /> | ||
| {isPublishable && <ApiKeySalesChannelSection apiKey={api_key} />} |
There was a problem hiding this comment.
very NIT, but it might be good to rename ApiKeySalesChannelSection to PublishableApiKeySection, since we can add more than sales channel to publishable keys
| <Link | ||
| to="/settings/api-key-management" | ||
| data-state={keyType === ApiKeyType.PUBLISHABLE ? "active" : ""} | ||
| className="txt-compact-small-plus transition-fg text-ui-fg-subtle hover:text-ui-fg-base focus-visible:border-ui-border-interactive focus-visible:!shadow-borders-focus focus-visible:bg-ui-bg-base data-[state=active]:text-ui-fg-base data-[state=active]:bg-ui-bg-base data-[state=active]:shadow-elevation-card-rest inline-flex items-center justify-center rounded-full border border-transparent bg-transparent px-2.5 py-1 outline-none" |
There was a problem hiding this comment.
This is a lot of styling 😄 Do we need to create some component for it instead?
There was a problem hiding this comment.
It's temporary, its the style from our Tabs component, but we don't actually want to use it here, so will have Ludvig come up with a new design after Recap 👍
What
Note
CLOSES CORE-1901