Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Minor fixes to region domain and api #7042

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

kasperkristensen
Copy link
Contributor

What

  • Minor fixes to styling of domain, and ensures that display_name is returned for countries.

Copy link

changeset-bot bot commented Apr 9, 2024

⚠️ No Changeset found

Latest commit: 68ab063

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 4:13pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 9, 2024 4:13pm
docs-ui ⬜️ Ignored (Inspect) Apr 9, 2024 4:13pm
medusa-docs ⬜️ Ignored (Inspect) Apr 9, 2024 4:13pm

@@ -78,7 +78,7 @@ export const CreateRegionForm = ({

const { t } = useTranslation()

const { mutateAsync, isLoading } = useCreateRegion()
const { mutateAsync, isPending } = useCreateRegion()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to switch to isPending everywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, isLoading was renamed to isPending in v5.

@kasperkristensen kasperkristensen merged commit 276278c into develop Apr 9, 2024
24 checks passed
@kasperkristensen kasperkristensen deleted the fix/v2-regions-cleanup branch April 9, 2024 16:46
pKorsholm pushed a commit that referenced this pull request Apr 16, 2024
pKorsholm added a commit that referenced this pull request Apr 25, 2024
…ns flow (#7080)

* add reservation endpoints

* add changeset

* initial

* add reservations table

* add edit-item modal

* udpate inventory item attributes

* manage locations skeleton

* add combi batch endpoint

* cleanup

* fix manage locations

* add adjust inventory

* prep for pr

* minor fixes to region domain and api (#7042)

* initial reservation

* init

* update reservation

* create reservation

* polishing

* minor fix

* prep for pr

* prep for pr

* polishing

* inventory items reservations

* Update packages/admin-next/dashboard/src/v2-routes/reservations/reservation-list/components/reservation-list-table/reservation-list-table.tsx

Co-authored-by: Frane Polić <16856471+fPolic@users.noreply.github.com>

* fix feedback

* rename to ispending

---------

Co-authored-by: Kasper Fabricius Kristensen <45367945+kasperkristensen@users.noreply.github.com>
Co-authored-by: Frane Polić <16856471+fPolic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants