Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: users domain #7070

Merged
merged 9 commits into from
Apr 16, 2024
Merged

refactor: users domain #7070

merged 9 commits into from
Apr 16, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Apr 15, 2024 •
edited

What

  • refactor users domain to use DataTable
  • add search params to User module models

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2024 •
edited

⚠️ No Changeset found

Latest commit: 8b28577

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 3:55pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 16, 2024 3:55pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 3:55pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 3:55pm

@fPolic fPolic marked this pull request as ready for review April 15, 2024 15:31
@fPolic fPolic requested a review from a team as a code owner April 15, 2024 15:31
@fPolic fPolic requested a review from sradevski April 15, 2024 15:31
olivermrbl
olivermrbl approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/admin-next/dashboard/src/hooks/table/query/use-user-invite-table-query.tsx Outdated Show resolved Hide resolved
...t/dashboard/src/v2-routes/users/user-invite/components/invite-user-form/invite-user-form.tsx Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 122b3ea into develop Apr 16, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the chore/refactor-users-domain branch April 16, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fPolic @olivermrbl