Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move several more endpoints to use zod for validation, unify APIs #7086

Merged
merged 2 commits into from
Apr 18, 2024
Merged

chore: Move several more endpoints to use zod for validation, unify APIs #7086

merged 2 commits into from
Apr 18, 2024

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested a review from a team as a code owner April 17, 2024 09:43
@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Apr 18, 2024 6:38am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 6:38am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 6:38am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 6:38am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024 •
edited

⚠️ No Changeset found

Latest commit: 7722d8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sradevski sradevski force-pushed the chore/move-to-zod-3 branch 2 times, most recently from 55c42bd to 3e30929 Compare April 17, 2024 14:24
olivermrbl
olivermrbl approved these changes Apr 17, 2024
View reviewed changes
packages/medusa/src/api-v2/admin/inventory-items/helpers.ts Outdated Show resolved Hide resolved
packages/medusa/src/api-v2/admin/inventory-items/helpers.ts
})

// TODO: Why does the response type change if you pass skip and take, vs not passing it?
// Also, why does the data change (in this case, not doing skip and take will not return the lazy fields of stockedQuantity and reserved_quantity)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems strange, did you check if this happens on regular list vs listAndCount calls?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivermrbl no I didn't, I didn't want to spend too much time on it, so I just opened a ticket as it is not an immediate blocker. I'll check if I have time today

@kodiakhq kodiakhq bot merged commit 44829f2 into develop Apr 18, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the chore/move-to-zod-3 branch April 18, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@pKorsholm pKorsholm Awaiting requested review from pKorsholm pKorsholm is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sradevski @olivermrbl