fix: Switch to zod for customer endpoints, fix inconsistencies #7094
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
| @@ -54,7 +54,7 @@ medusaIntegrationTestRunner({ | |||
| ) | |||
|
|
|||
| const response = await api.get( | |||
| `/admin/customer-groups/${group.id}/customers`, | |||
There was a problem hiding this comment.
This is an anti-pattern and we should just use the customers endpoint with a filter (as done for eg. for products and price lists)
| @@ -0,0 +1,66 @@ | |||
| import { AdminCustomerGroupResponse, BatchMethodRequest } from "@medusajs/types" | |||
There was a problem hiding this comment.
A general thought: Are we sure we want to remove existing batch endpoints? If so, I think we keep adding todos to the admin clean-up. Maybe keeping these in and removing them in our polishing phase is better?
There was a problem hiding this comment.
@olivermrbl it's a pretty small change in 1 place, so I'd rather do it sooner than later. I am actually planning to just unify all of the batch endpoints in 1 go, both on FE and BE as it will be faster
No description provided.