Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move most of the remaining endpoints to zod #7096

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested a review from a team as a code owner April 18, 2024 09:20
Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: 67a311c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Apr 18, 2024 9:42am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 9:42am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 9:42am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 9:42am

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

)
}

if (create && create.length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (create && create.length) {
if ( create?.length) {

}
}

if (toDelete && toDelete.length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (toDelete && toDelete.length) {
if (toDelete?.length) {

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

],
}

const { errors } = await removeSalesChannelsFromApiKeyWorkflow(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: any reason why these aren't in one workflow?

Context - if the delete fails, you can't revert the creates. If the case is that only one is running at a time, maybe we can do an XOR validation with zod

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riqwan I'll move them to a single workflow, it was just too many changes to do at once so I figured I'll just make the user-facing HTTP interface to what we want it to be first

@sradevski sradevski merged commit be00a2e into develop Apr 18, 2024
24 checks passed
@sradevski sradevski deleted the chore/move-to-zod-4 branch April 18, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants