-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move most of the remaining endpoints to zod #7096
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
2f8ccd9
to
67a311c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) | ||
} | ||
|
||
if (create && create.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (create && create.length) { | |
if ( create?.length) { |
} | ||
} | ||
|
||
if (toDelete && toDelete.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (toDelete && toDelete.length) { | |
if (toDelete?.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏻
], | ||
} | ||
|
||
const { errors } = await removeSalesChannelsFromApiKeyWorkflow( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: any reason why these aren't in one workflow?
Context - if the delete fails, you can't revert the creates. If the case is that only one is running at a time, maybe we can do an XOR validation with zod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riqwan I'll move them to a single workflow, it was just too many changes to do at once so I figured I'll just make the user-facing HTTP interface to what we want it to be first
No description provided.