feat(core-flows,medusa,types): fulfillment API: create #7101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a54729a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
riqwan
force-pushed
the
feat/fulfillment-create-api
branch
from
d9ec1a1
to
a2856d3
Compare
olivermrbl
reviewed
Apr 22, 2024
packages/core-flows/src/fulfillment/steps/create-fulfillment.ts
Outdated
Show resolved
Hide resolved
packages/core-flows/src/fulfillment/steps/create-fulfillment.ts
Outdated
Show resolved
Hide resolved
sradevski
reviewed
Apr 22, 2024
| items: z.array( | ||
| z.object({ | ||
| title: z.string(), | ||
| sku: z.string(), |
There was a problem hiding this comment.
Are both an SKU and barcode required?
There was a problem hiding this comment.
According to the module, both are required. Any reason why it wouldn't be?
There was a problem hiding this comment.
@riqwan both are unique identifiers, so I was wondering if it's enough to have one or the other
sradevski
approved these changes
Apr 22, 2024
…ts (#7118) * feat(core-flows,medusa,types): add update api for fulfillments * chore: add create shipment api * chore: remove update endpoint * chore: update changeset * chore: added comment * chore: throw on error in workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what:
RESOLVES CORE-1962