feat: Add s3-compatible plugin for the file module #7143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
sradevski
force-pushed
the
feat/add-s3-file-provider
branch
from
d1345c6
to
498b1b6
Compare
olivermrbl
approved these changes
Apr 24, 2024
| const content = Buffer.from(file.content, "binary") | ||
| const command = new PutObjectCommand({ | ||
| // TODO: Add support for private files | ||
| // We probably also want to support a separate bucket altogether for private files |
There was a problem hiding this comment.
Yeah I think that sounds reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have run the tests against Minio, DO, and AWS and it's looking fine.