Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa, core-flows, types): Allow to update the rules from a shipping options #7175

Merged
merged 7 commits into from Apr 30, 2024
Merged

feat(medusa, core-flows, types): Allow to update the rules from a shipping options #7175

merged 7 commits into from Apr 30, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Apr 30, 2024 •
edited

What
Add support for the following operations

  • update rules from the update shipping options end point
  • update rules from the batch update end point

Also added some improvements, that can be revisited later

  • Add a rule value normalizer, jsonb will transform the input value to a primitive when possible meaning that passing "true" will result in storing true and not the string. The normalizer takes care of that

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2024 •
edited

🦋 Changeset detected

Latest commit: a0d09e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/medusa Patch
@medusajs/core-flows Patch
@medusajs/fulfillment Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:30pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 30, 2024 4:30pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:30pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:30pm

@fPolic fPolic mentioned this pull request Apr 30, 2024
Merged
1 task
@adrien2p adrien2p marked this pull request as ready for review April 30, 2024 11:19
@adrien2p adrien2p requested a review from a team as a code owner April 30, 2024 11:19
fPolic
fPolic approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@adrien2p
Copy link
Member Author

@fPolic should I merge?

@fPolic
Copy link
Contributor

fPolic commented Apr 30, 2024

@fPolic should I merge?

Yes please 🚢

@kodiakhq kodiakhq bot merged commit e26cda4 into develop Apr 30, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the feat/shipping-options-rules-operations branch April 30, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@fPolic fPolic fPolic approved these changes

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrien2p @fPolic @sradevski