Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Accept filters in softDelete + fulfillment location clean-up #7198

Merged
merged 4 commits into from
May 3, 2024
Merged

fix: Accept filters in softDelete + fulfillment location clean-up #7198

merged 4 commits into from
May 3, 2024

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 15028c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 4:15pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 3, 2024 4:15pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 4:15pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 4:15pm

@olivermrbl
Copy link
Contributor Author

@adrien2p, I might need you to take over on this one. We need to support filter-based soft deletes similar to what we support in regular deletes. Otherwise, cascading soft-deletes will not work as expected. We can huddle about this.

@olivermrbl olivermrbl marked this pull request as ready for review May 2, 2024 13:14
@olivermrbl olivermrbl requested a review from a team as a code owner May 2, 2024 13:14
@olivermrbl olivermrbl force-pushed the fix/location-fulfillment-sets branch from ce16e81 to d833e4f Compare May 3, 2024 14:38
@olivermrbl olivermrbl force-pushed the fix/location-fulfillment-sets branch from d833e4f to f18fa7d Compare May 3, 2024 14:48
@olivermrbl olivermrbl force-pushed the fix/location-fulfillment-sets branch from 47e4e32 to 15028c0 Compare May 3, 2024 16:11
@kodiakhq kodiakhq bot merged commit 2f7b534 into develop May 3, 2024
22 checks passed
@kodiakhq kodiakhq bot deleted the fix/location-fulfillment-sets branch May 3, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p left review comments

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olivermrbl @adrien2p @carlos-r-l-rodrigues