Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid returning draft-orders from /orders endpoint #7302

Merged
merged 1 commit into from May 14, 2024
Merged

Avoid returning draft-orders from /orders endpoint #7302

merged 1 commit into from May 14, 2024

Conversation

josetr
Copy link
Contributor

@josetr josetr commented May 12, 2024

I'm assuming the current behavior of returning all kind of orders is not the right one since we already have a /draft-orders endpoint.

@josetr josetr requested a review from a team as a code owner May 12, 2024 10:37
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 12, 2024

⚠️ No Changeset found

Latest commit: a68ea31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 12, 2024

@josetr is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sradevski sradevski merged commit ad007ad into medusajs:develop May 14, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josetr @carlos-r-l-rodrigues @sradevski