Use album_title field as title. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if Bandcamp changed their API or what, but my downloads do not have a "title" field in them, causing the tool to loop endlessly through all purchases and not download anything; this change fixes said problem for me, but I saw that the response also includes keys such as "item_title", which might be a more robust choice.
|
Thanks! Quite possibly this is a remote change. Bandcampsync slurps the JSON data used for the SPA web interface so it's quite likely this changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Not sure if Bandcamp changed their API or what, but my downloads do not have a
titlefield in them, causing the tool to loop endlessly through all purchases and not download anything; this change fixes said problem for me, but I saw that the response also includes keys such asitem_title, which might be a more robust choice, but I haven't tested it.