Use ordinal comparisons when parsing IRC messages.

Fixes a bug where messages starting with "combining" Unicode characters cause the parser to fail. Likely improves performance too.
meebey · Jul 20, 2013 · 309ad84 · 309ad84
1 parent 291abb2
commit 309ad84
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/IrcClient/IrcClient.cs b/src/IrcClient/IrcClient.cs
@@ -901,9 +901,9 @@ public IrcMessageData MessageParser(string rawline)
             // conform to RFC 2812
             from = linear[0];
             messagecode = linear[1];
-            exclamationpos = from.IndexOf("!");
-            atpos = from.IndexOf("@");
-            colonpos = line.IndexOf(" :");
+            exclamationpos = from.IndexOf("!", StringComparison.Ordinal);
+            atpos = from.IndexOf("@", StringComparison.Ordinal);
+            colonpos = line.IndexOf(" :", StringComparison.Ordinal);
             if (colonpos != -1) {
                 // we want the exact position of ":" not beginning from the space
                 colonpos += 1;