-
Notifications
You must be signed in to change notification settings - Fork 46
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Engine(-IRC): prevent highlights from self (closes: #1095)
In theory, IRC is designed in a way in which all messages from your current handle are always sent from your own client. However, with the advent of IRC bridges, such as the Slack one, it's feasible to use your IRC handle from 2 places: smuxi and the web (slack UI). In this case, when you sent a message using the latter, you would get a smuxi highlight on the former because the engine receives a message that contains your nick, which is essentially a false positive. This can be workarounded by adding a comparison to Me's property in MessageBuilder class just before highlighting.
- Loading branch information
Showing
2 changed files
with
14 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters