Collect user data and integrate error page with Intercom #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit puts an ErrorBoundary around each Route's parent component. This way each ErrorBoundary is under the IntlProvider and has Intercom in scope so we integrate and prefill support request messages when crashes happen. ErrorBoundary component now gets a `component` prop to specify which component it is wrapping and this will be sent with the errbit report. It is also collecting user name, dbid and email to send with the report, to help gain more insight/context on the crashes. Note I: The @airbrake-js/browser calls to the Errbit server seem to ignore the extra data added as context, params and session, unless the error is a string or we cast a new instance from the raised error object. To be investigated. See github issue: airbrake/airbrake-js#1193 Note II: MainErrorBoundary has been renamed to ErrorBoundary Fixes: CHECK-1744
dariusk
reviewed
Apr 22, 2022
| @@ -294,6 +294,9 @@ class MediaComponent extends Component { | |||
| media.quote = media.media.quote; | |||
| media.embed_path = media.media.embed_path; | |||
|
|
|||
| // console.log(this.props.trololo.meajude.xocxoc); // eslint-disable-line no-console | |||
| console.log(JSON.parse('bli')); // eslint-disable-line no-console | |||
There was a problem hiding this comment.
Thanks! Fixing this! Not only a console.log but one with a runtime error in it! 😅
dariusk
reviewed
Apr 22, 2022
| id | ||
| slug | ||
| permissions |
There was a problem hiding this comment.
I see you moved slug and permissions into a subquery here, just making sure that was as intended. I don't see any code changes made in response to this move, which is why I ask, but maybe I'm missing one.
There was a problem hiding this comment.
I didn't. They're under team all along. I guess it's the crazy diff visualization that may suggest it, but thanks for pointing!
dariusk
reviewed
Apr 22, 2022
| @@ -64,8 +64,12 @@ function getStatusStyle(status, property) { | |||
| * Truncate a string and append ellipsis. | |||
| */ | |||
| function truncateLength(str, length = 70) { | |||
| const dots = str.length > length ? '...' : ''; | |||
| return `${str.substring(0, length)}${dots}`; | |||
| if (typeof str === 'string') { | |||
There was a problem hiding this comment.
Ah nice catch, wouldn't want this attempting to substr an Array.
dariusk
reviewed
Apr 22, 2022
Also to mention that change in helpers.js is to guard agains `null` value for `str`. Fixes CHECK-1747
caiosba
reviewed
Apr 23, 2022
| params: { info: errorInfo }, | ||
| session: { name, dbid, email }, | ||
| }).then((response) => { | ||
| if (Intercom) { |
There was a problem hiding this comment.
Didn't you need to declare "global Intercom" on top? The Linter didn't complain?
caiosba
approved these changes
Apr 23, 2022
amoedoamorim
added a commit
that referenced
this pull request
Apr 25, 2022
* Collect user data and integrate error page with Intercom This commit puts an ErrorBoundary around each Route's parent component. This way each ErrorBoundary is under the IntlProvider and has Intercom in scope so we integrate and prefill support request messages when crashes happen. ErrorBoundary component now gets a `component` prop to specify which component it is wrapping and this will be sent with the errbit report. It is also collecting user name, dbid and email to send with the report, to help gain more insight/context on the crashes. Note I: The @airbrake-js/browser calls to the Errbit server seem to ignore the extra data added as context, params and session, unless the error is a string or we cast a new instance from the raised error object. To be investigated. See github issue: airbrake/airbrake-js#1193 Note II: MainErrorBoundary has been renamed to ErrorBoundary Fixes: CHECK-1744 * Remove console log with intentional error 😅 Also to mention that change in helpers.js is to guard agains `null` value for `str`. Fixes CHECK-1747 * Add missing files 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit puts an ErrorBoundary around each Route's parent component.
This way each ErrorBoundary is under the IntlProvider and has Intercom in scope so we integrate and prefill support request messages when crashes happen.
ErrorBoundary component now gets a
componentprop to specify which component it is wrapping and this will be sent with the errbit report.It is also collecting user name, dbid and email to send with the report, to help gain more insight/context on the crashes.
Note I: The @airbrake-js/browser calls to the Errbit server seem to ignore the extra data added as context, params and session, unless the error is a string or we cast a new instance from the raised error object. To be investigated. See github issue: airbrake/airbrake-js#1193
Note II: MainErrorBoundary has been renamed to ErrorBoundary
Fixes: CHECK-1744