Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/5660 log title change #58

Merged
merged 4 commits into from Feb 14, 2017
Merged

Feature/5660 log title change #58

merged 4 commits into from Feb 14, 2017

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Feb 14, 2017

No description provided.

caiosba
caiosba approved these changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, given the assumption that the only thing we change today in the embed annotation is the title and that there is only embed annotation per project_media.

@melsawy melsawy merged commit d279aa6 into develop Feb 14, 2017
@melsawy melsawy deleted the feature/5660-log-title-change branch February 14, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiosba caiosba caiosba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@melsawy @caiosba