Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to override HTTPS TLS context #379

Merged
merged 3 commits into from
May 16, 2023
Merged

Add the ability to override HTTPS TLS context #379

merged 3 commits into from
May 16, 2023

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst commented May 16, 2023 •
edited
Loading

Fixes #377

Todo:

  • Manual testing that it didn't break anything
  • Manual test to ensure custom TLS contexts actually work
  • Unit testing for custom TLS context factory

@itamarst itamarst marked this pull request as draft May 16, 2023 16:04
@itamarst itamarst marked this pull request as ready for review May 16, 2023 17:12
@coveralls
Copy link

coveralls commented May 16, 2023 •
edited
Loading

Coverage Status

Coverage: 99.571% (-0.07%) from 99.644% when pulling d4363d2 on itamarst:377.custom-web-context into c950149 on meejah:main.

@meejah
Copy link
Owner

meejah commented May 16, 2023

Ooof, forgot how much "mock" was in the test-suite :(

Looks great! The only thing I (maybe) noticed is that all the tests now pass pool= I think? But, not a huge deal.

@meejah
remove release title
d4363d2 
I usually add the release title / number when actually doing the release.
meejah
meejah approved these changes May 16, 2023
View reviewed changes
Copy link
Owner

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(I thought doing the "edit" would produce a suggestion -- re the release-notes).

@meejah
Copy link
Owner

meejah commented May 16, 2023

(Hmmm, I think some of the "coverage loss" is because py2 is dropped, but I didn't remove all the py2-only lines?)

@itamarst
Copy link
Collaborator Author

I believe the tests passed pool in previously too.

@itamarst itamarst merged commit 5753ad1 into meejah:main May 16, 2023
@itamarst itamarst deleted the 377.custom-web-context branch May 16, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah meejah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

twisted.web Agent created by txtorcon should accept other Agent options
4 participants
@itamarst @coveralls @meejah @pythonspeed