Change skill logic. second try #93

TehDmitry · 2018-06-23T21:38:42Z

use meteor by cooldown in center-line
use blackhole in center-line
use bomb if enemy hp > 30
select more effective target for bomb
reduce enemy scoring if they will be affected by meteor

instead #84 (I ruined branch by rebase)

EoD · 2018-06-24T12:43:45Z

index.user.js

+        this.attack();
+    }
+    attack() {
+        SetMouse(k_nDamagePointx + 50,  (APP.renderer.height / 2) + 100);


Where does this 50 come from? Is it the size of the Meteor sprite?

@TehDmitry ping

k_nDamagePointx + 50 — is just little bit right from left side of screen

EoD · 2018-06-24T12:45:02Z

index.user.js

+        if (enemy.m_bDead || EnemyWillAffectedByBoulder(enemy) || BlackholeOfEnemy(enemy) != null)
+            return WORST_SCORE;
+
+        let score =  AllEnemiesHPNearPoint(enemy.m_Sprite.x, enemy.m_Sprite.y, 50);


Where does the 50 come from? Is it the size of the Projectile sprite?

EoD · 2018-06-24T12:46:40Z

index.user.js

+}
+const AllEnemiesHPNearPoint = function AllEnemiesHPNearPoint(x,  y, radius) {
+    let hp = 0;
+    EnemyManager().m_rgEnemies.forEach((enemy) => {


I am not an expert on JS, but do you really want to execute a forEach here? Couldn't it be async and hence hp will always be 0?

yes you do since m_rgEnemies is a Map object

@meepen so it is guaranteed to not to be async? What about the following approach?

for(var [_, enemy] of EnemyManager().m_rgEnemies) { // If something hp += enemy.m_nHealth; }

TehDmitry · 2018-06-24T14:00:01Z

changed

EoD · 2018-06-24T14:19:15Z

index.user.js

@@ -402,7 +408,8 @@ class BombAttack extends ProjectileAttack {
        if (enemy.m_bDead || EnemyWillAffectedByBoulder(enemy) || BlackholeOfEnemy(enemy) != null)
            return WORST_SCORE;

-        let score =  AllEnemiesHPNearPoint(enemy.m_Sprite.x, enemy.m_Sprite.y, 50);
+        let explosionWidth = GAME.m_State.m_AttackManager.m_rgExplosionFrames[0].width * 0.4; //attack.js:353 value is 204.8


Nice find. Instead of * 0.4 you could use GAME.m_State.m_AttackManager.m_rgExplosionFrames[0].scale[1] can you not?

m_rgExplosionFrames[0] doesn't have the scale property:

console.log(gGame.m_State.m_AttackManager.m_rgExplosionFrames[0].scale)
undefined

Fair enough, you would need to get the AnimatedSprite. Let's Meepen decide.

var explosion = new PIXI.extras.AnimatedSprite(instance.m_rgExplosionFrames ); explosion.animationSpeed = 0.2; explosion.loop = false; explosion.play(); explosion.scale.set( 0.4, 0.4 ); explosion.anchor.set( 0.5, 0.5 );

EoD · 2018-06-24T14:21:26Z

index.user.js

+const CenterOfSpawnZoneYpos = function CenterOfSpawnZoneX(enemy) {
+    //slime from enemies.json has scale 0.5
+    //texture has height 126
+    let minSpriteHeight = 126 * 0.5;


Can't you use enemy.m_Sprite.height here? Something similar for the scale?

enemy is excess here, fixed

@TehDmitry I am more worried about the 126 and the 0.5 here. Where are they coming from?

https://steamcdn-a.akamaihd.net/steamcommunity/public/assets//saliengame/enemies.json
"slime":{
…
"scale": {
"x":0.5,
"y":0.5
},

PIXI.loader.resources['enemy-spritesheet-0'].textures['Enemy_A_0007.png'].height
126

TehDmitry · 2018-06-24T19:00:52Z

Is this changes enough?

EoD · 2018-06-24T19:41:28Z

@TehDmitry we are getting there! Except for the magic numbers mentioned above, is there a reason why you are overloading attack() instead of targetPosition(target)?

TehDmitry · 2018-06-24T20:03:25Z

@EoD because I don't have the target for Meteor and Blackhole attacks

TehDmitry · 2018-06-24T23:53:09Z

@EricMue in this branch I don't change coordinates for bomb attack, only enemy scoring for finding best enemy group.
But you are right. Sometimes when black hole is active — bomb is missing

EoD · 2018-06-25T00:28:57Z

@meepen what is your take on this?

TehDmitry · 2018-06-25T14:03:35Z

I think we are making ideal code instead making fun

Kefta · 2018-06-26T05:23:46Z

ideal code is fun

TehDmitry · 2018-06-30T14:57:31Z

I don't know what they want.
Without approving requests is no motivation to create them. For example I already have boss support

meepen · 2018-06-30T16:57:37Z

Ideally you should make multiple requests for the different features, suck as this and boss support, I recently started to start using user script again so I will be able to look at these changes again

…

On Sat, Jun 30, 2018, 10:57 AM TehDmitry ***@***.***> wrote: I don't know what they want. Without approving requests is no motivation to create them. For example I already have boss support — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF5lSadQK6EekDL2S7y-4Wti1kkuXnRVks5uB5HcgaJpZM4U08GY> .

TehDmitry · 2018-07-02T13:46:20Z

In next minigame I will try to be better.
But with 7-day-long PR reviews it's a little bit hard.

Bot is outdating too fast.
For example is any reason to use this ideal script without boss support instead not ideal but with support?
Maybe ideal support a month later will be better?

I will remind you only two days left for fun.
But #171 with most important feature is still open for 8 hour.

Seems to be too many enterprise-way for this fun game

Change skill logic. second try

304ca02

meepen added the userscript label Jun 23, 2018

TehDmitry mentioned this pull request Jun 24, 2018

Meteor (Black Hole) use #100

Open

EoD suggested changes Jun 24, 2018

View reviewed changes

calculate center of the spawnzone

b86be2d

EoD reviewed Jun 24, 2018

View reviewed changes

EoD suggested changes Jun 24, 2018

View reviewed changes

TehDmitry added 2 commits June 24, 2018 21:43

CenterOfSpawnZoneYpos doesn't depend on enemy

b2777d6

make more ideal code

d8ca7ae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change skill logic. second try #93

Change skill logic. second try #93

TehDmitry commented Jun 23, 2018

EoD Jun 24, 2018

EoD Jun 24, 2018

TehDmitry Jun 24, 2018

EoD Jun 24, 2018

EoD Jun 24, 2018 •

edited

Loading

meepen Jun 24, 2018

EoD Jun 24, 2018

TehDmitry commented Jun 24, 2018

EoD Jun 24, 2018

TehDmitry Jun 24, 2018

EoD Jun 24, 2018

EoD Jun 24, 2018

TehDmitry Jun 24, 2018

EoD Jun 24, 2018

TehDmitry Jun 24, 2018

TehDmitry commented Jun 24, 2018

EoD commented Jun 24, 2018

TehDmitry commented Jun 24, 2018

TehDmitry commented Jun 24, 2018

EoD commented Jun 25, 2018

TehDmitry commented Jun 25, 2018

Kefta commented Jun 26, 2018

TehDmitry commented Jun 30, 2018

meepen commented Jun 30, 2018 via email

TehDmitry commented Jul 2, 2018

Change skill logic. second try #93

Are you sure you want to change the base?

Change skill logic. second try #93

Conversation

TehDmitry commented Jun 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EoD Jun 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TehDmitry commented Jun 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TehDmitry commented Jun 24, 2018

EoD commented Jun 24, 2018

TehDmitry commented Jun 24, 2018

TehDmitry commented Jun 24, 2018

EoD commented Jun 25, 2018

TehDmitry commented Jun 25, 2018

Kefta commented Jun 26, 2018

TehDmitry commented Jun 30, 2018

meepen commented Jun 30, 2018 via email

TehDmitry commented Jul 2, 2018

EoD Jun 24, 2018 •

edited

Loading