-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websocket transport disconnected occasionally #2081
Comments
That's exactly what we do, if you even bothered to check the code. But it you think that's not the case, I will consider "fixing my code" when you say "please". |
I'm sorry for your misunderstand, “fix your code” is part of libwebsockets log, Not added by me |
Sorry about that, I shouldn't read mails early in the morning... 😊 |
I'm appreciated for all your guys amazing work! I googled and found this post, warmcat/libwebsockets#852 It seems we should test lws_send_pipe_choked before call lws_write when receive LWS_CALLBACK_SERVER_WRITEABLE But I'm not sure whether this will fix the bug, I'm going to test it for a while. |
Ah, thanks for the pointer! This comment makes sense indeed:
as we do have a mechanism to send pending data. I'll have to check if we try to send more stuff in sequence, which is likely. I'll keep you posted. |
Mh, no, that's not our case: I verified and in the |
I tested for some days in production environment, |
Closing as the fix was merged. |
I use videoroom plugin with websocket transport, most time janus works well, but occasionally websocket will disconnect, the janus log file output:
[libwebsockets][ERR] ****** 0x7fe6cc0026e0: Sending new 187 (<81>~), pending truncated ...
It's illegal to do an lws_write outside of
the writable callback: fix your code
The text was updated successfully, but these errors were encountered: