Make NACK buffer cleanup on outgoing keyframe configurable (see #2401) #2402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this post and #2401 for reference.
This PR adds a new
janus.jcfg
property callednack_optimizations
to enable the behaviour master currently has, that is, the ability to clean the NACK buffer any time we're sending a keyframe to the peer. Quoting from the configuration file, which explains the property and the rationale:The property can also be dynamically changed via Admin API, e.g.: