demos: update webrtc adapter 8.0.0 #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lminiero
reviewed
Jun 14, 2021
| @@ -33,6 +33,6 @@ | |||
| "tests" | |||
| ], | |||
| "dependencies": { | |||
| "webrtc-adapter": "7.7.0" | |||
| "webrtc-adapter": "8.0.0" | |||
There was a problem hiding this comment.
Did you test this too? I remember bower having issues because the version available online wasn't available there too.
There was a problem hiding this comment.
Just running sorry, you're asking about bower:npm install within the janus directory, but worked as expected (it found webrtc-adapter 8.0.0 and installed it in node_modules).
tmatth@bellini:~/src/janus-gateway$ ./node_modules/bower/bin/bower install
bower webrtc-adapter#8.0.0 not-cached https://github.com/webrtc/adapter.git#8.0.0
bower webrtc-adapter#8.0.0 resolve https://github.com/webrtc/adapter.git#8.0.0
bower webrtc-adapter#8.0.0 download https://github.com/webrtc/adapter/archive/v8.0.0.tar.gz
bower webrtc-adapter#8.0.0 extract archive.tar.gz
bower webrtc-adapter#8.0.0 resolved https://github.com/webrtc/adapter.git#8.0.0
bower webrtc-adapter#8.0.0 install webrtc-adapter#8.0.0
webrtc-adapter#8.0.0 bower_components/webrtc-adapter
tmatth
force-pushed
the
update/webrtc-adapter-8.0.0
branch
2 times, most recently
from
22bc7fd
to
e4ad491
Compare
Breaking changes [1]: * remove legacy edge + rtcpeerconnection-shim (see meetecho#1076) * RTCIceCandidate polyfill is now polyfilled according to spec (see meetecho#999) [1] https://github.com/webrtcHacks/adapter/releases/tag/v8.0.0
tmatth
force-pushed
the
update/webrtc-adapter-8.0.0
branch
from
e4ad491
to
fc41bcb
Compare
|
Ok, we finally managed to test with Edge, which worked (at least what we tried) so I'll merge, thanks 👍 |
|
I should clarify that we tested with the new Chromium-based Edge, not the old one: but since I don't really care about that one, I think we can safely ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with webrtc-adapter tags not being published to cdnjs has been resolved, see:
cdnjs/packages#746
Tested locally (note: I don't have edge).