New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gstreamer 1.0 command variant for generating gstreamer test stream #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipeline I wrote had some additional vp8enc parameters to make it more "lightweight" and fast. In fact, at least in gstreamer 0-10, the default settings of vp8enc were quite CPU hungry, and made it difficult to run on older machines. I'll check if the parameters have changed in 1.0 and add it to your variant, if needed, thanks for that! |
meetecho
pushed a commit
that referenced
this pull request
Feb 13, 2014
Added gstreamer 1.0 command variant for generating gstreamer test stream
Closed
Closed
Closed
Closed
Closed
DmitryYudin
added a commit
to DmitryYudin/janus-gateway
that referenced
this pull request
Sep 17, 2018
mom-informative stack unwind if leak detected in so-module ====================================================================================== default: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603af545c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603afa61a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s). ====================================================================================== no_fast_unwind: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d445c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f35537d9646 in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x8646) meetecho#3 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#4 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#5 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d961a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#3 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#4 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s).
DmitryYudin
added a commit
to DmitryYudin/janus-gateway
that referenced
this pull request
Sep 17, 2018
mom-informative stack unwind if leak detected in so-module ====================================================================================== default: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603af545c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603afa61a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s). ====================================================================================== no_fast_unwind: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d445c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f35537d9646 in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x8646) meetecho#3 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#4 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#5 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d961a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#3 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#4 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s).
lminiero
added a commit
that referenced
this pull request
Sep 18, 2018
nosip: resource leak if no answer received
DmitryYudin
added a commit
to DmitryYudin/janus-gateway
that referenced
this pull request
Sep 19, 2018
mom-informative stack unwind if leak detected in so-module ====================================================================================== default: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603af545c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603afa61a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s). ====================================================================================== no_fast_unwind: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d445c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f35537d9646 in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x8646) meetecho#3 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#4 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#5 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d961a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#3 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#4 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s).
Closed
DmitryYudin
added a commit
to DmitryYudin/janus-gateway
that referenced
this pull request
Oct 18, 2018
mom-informative stack unwind if leak detected in so-module ====================================================================================== default: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603af545c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603afa61a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s). ====================================================================================== no_fast_unwind: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d445c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f35537d9646 in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x8646) meetecho#3 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#4 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#5 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d961a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#3 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#4 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s).
DmitryYudin
added a commit
to DmitryYudin/janus-gateway
that referenced
this pull request
Oct 18, 2018
mom-informative stack unwind if leak detected in so-module ====================================================================================== default: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603af545c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603afa61a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s). ====================================================================================== no_fast_unwind: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d445c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f35537d9646 in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x8646) meetecho#3 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#4 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#5 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d961a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#3 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#4 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s).
DmitryYudin
added a commit
to DmitryYudin/janus-gateway
that referenced
this pull request
Dec 28, 2018
mom-informative stack unwind if leak detected in so-module ====================================================================================== default: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603af545c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603afa61a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s). ====================================================================================== no_fast_unwind: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d445c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f35537d9646 in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x8646) meetecho#3 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#4 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#5 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d961a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#3 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#4 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s).
DmitryYudin
added a commit
to DmitryYudin/janus-gateway
that referenced
this pull request
Dec 28, 2018
mom-informative stack unwind if leak detected in so-module ====================================================================================== default: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603af545c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603afa61a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s). ====================================================================================== no_fast_unwind: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d445c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f35537d9646 in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x8646) meetecho#3 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#4 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#5 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d961a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#3 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#4 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s).
DmitryYudin
added a commit
to DmitryYudin/janus-gateway
that referenced
this pull request
Jan 24, 2019
mom-informative stack unwind if leak detected in so-module ====================================================================================== default: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603af545c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f36052b0b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f3603afa61a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x7f3602808b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s). ====================================================================================== no_fast_unwind: Indirect leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d445c (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x345c) meetecho#2 0x7f35537d9646 in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x8646) meetecho#3 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#4 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#5 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) Indirect leak of 72 byte(s) in 1 object(s) allocated from: #0 0x7f3554f8fb50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50) meetecho#1 0x7f35537d961a in json_object (/usr/lib/x86_64-linux-gnu/libjansson.so.4+0x861a) meetecho#2 0x55928c01143a in main /home/dima/work/janus.github/src/janus.c:3269 meetecho#3 0x7f35524e7b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96) meetecho#4 0x55928bfc74c9 in _start (/home/dima/work/janus.github/cmake-gcc/janus+0x1364c9) SUMMARY: AddressSanitizer: 200 byte(s) leaked in 2 allocation(s).
Closed
This was referenced Jul 5, 2019
Closed
Closed
IbrayevRamil
added a commit
to IbrayevRamil/janus-gateway
that referenced
this pull request
Aug 7, 2023
IbrayevRamil
added a commit
to IbrayevRamil/janus-gateway
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this will be helpful to people or not, but I've got 1.0 gstreamer compiled on my dev machine and needed to change the pipeline to make it 1.0 compatible. I know almost nothing about gstreamer though so I'm not sure if this is right - but it worked for me :)