fix(App): Bugfix Fix memory leak in recipe polling loop

meetfranz · Feb 7, 2018 · c99848f · c99848f
1 parent a585f2b
commit c99848f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/models/Service.js b/src/models/Service.js
@@ -6,6 +6,7 @@ export default class Service {
   id = '';
   recipe = '';
   webview = null;
+  timer = null;
   events: {};
 
   isAttached = false;

diff --git a/src/stores/ServicesStore.js b/src/stores/ServicesStore.js
@@ -589,12 +589,16 @@ export default class ServicesStore extends Store {
     const delay = 1000;
 
     if (service) {
+      if (service.timer !== null) {
+        clearTimeout(service.timer)
+      }  
+
       const loop = () => {
         if (!service.webview) return;
 
         service.webview.send('poll');
 
-        setTimeout(loop, delay);
+        service.timer = setTimeout(loop, delay);
       };
 
       loop();