Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron globalShortcut 'Alt+Shift+F' to toggle between 'Show/Hide Franz' #1399

Closed
wants to merge 2 commits into from
Closed

Add Electron globalShortcut 'Alt+Shift+F' to toggle between 'Show/Hide Franz' #1399

wants to merge 2 commits into from

Conversation

mcmxcdev
Copy link

Description

Added shortcut Alt+Shift+F to toggle between 'Show/Hide Franz', which is a faster way then going to the System Bar Tray Icon and clicking it.

Motivation and Context

Feature request can be found here: #1218

How Has This Been Tested?

Tested on Ubuntu 18.10.
Verified with different applications that the global shortcut Alt+Shift+F doesn't collide with default shortcuts of the tested applications.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project (run $ yarn lint).

…e Franz', fix type mismatch for Button IProps type property

Signed-off-by: mhatvan <markus_hatvan@aon.at>
@adlk
Copy link
Contributor

adlk commented Apr 16, 2019

@mhatvan Thanks for adding this.

We thought about that for quite some time in the past. If we are going to add a global shortcut it must be customizable for the user. Especially since global listener have so much potential for conflicts.

If you are willing to tackle this then I'm more than happy to write down the specs.

@mcmxcdev
Copy link
Author

hey @adlk,

I also had in mind that we could define default global shortcuts and then let the user customize them, in case they use an application shortcut that collides with it or just for fun, but decided against it since I didn't want to do UI changes without your knowledge.

Yes, I want to tackle this and it would be great to have mockups or some other visual reference of how you imagine it to look like for the users.

@adlk adlk changed the base branch from master to develop April 16, 2019 16:48
@mcmxcdev
Copy link
Author

mcmxcdev commented May 5, 2019

@adlk any updates from your side so that I can start working on customizable shortcuts?

@mcmxcdev
Copy link
Author

@adlk is there still any interest from your side to implement this? Otherwise I will close the PR.

@mcmxcdev mcmxcdev closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants