change icon to include more sizes #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now comes with 16, 24, 32, 48, 64, 128, 192, 256 sizes vs the previous 16, 32, 48, 64, 128, 256
|
@Stanzilla wow, great work! will try to merge this ASAP 👍 |
adlk
approved these changes
Feb 14, 2018
haraldox
approved these changes
Feb 14, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Windows taskbar icon being a bit blurry (https://github.com/meetfranz/franz/issues/613#issuecomment-364954140)
Description
The app icon now comes with 16, 24, 32, 48, 64, 128, 192, 256 sizes vs the previous 16, 32, 48, 64, 128, 256
Currently it somehow only uses the newer icon when I unpin the app from the taskbar but I guess that is a caching issue.
Motivation and Context
https://github.com/meetfranz/franz/issues/613#issuecomment-364954140
How Has This Been Tested?
Screenshots (if appropriate):
Before:
After:
https://i.imgur.com/4Zjph86.png
Types of changes
Checklist:
$ yarn lint).