Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 4 system blackbox separate gearslothds #14

Merged
merged 8 commits into from
Jun 17, 2014

Conversation

Virta
Copy link

@Virta Virta commented Jun 12, 2014

Blackbox tests where instances of gearslothd are used separately. The tests use an sqlite adapter with 100 ms poll_timeout.

  • a single instance of all components
    • immediate execution
  • three instances of all components
    • immediate execution
    • 6 second delay execution

Tests do not pass locally or on vagrant, probably because a component fails. It seems that a task is sent to multiple bottom level workers when it expires. Perhaps something to do with the adapter not locking the task in time due to the lack of locking?

@Virta
Copy link
Author

Virta commented Jun 16, 2014

I cannot reproduce the failures anymore on the 'multiple instances' tests; before several bottom level workers got the task, which is in error of the protocol we're building.

@Virta
Copy link
Author

Virta commented Jun 16, 2014

The error, thankfully was in the tests I built. The function to submit the job was called many times; at first it was done when the last bottom level worker connected (but it sent several 'connect' events), then at the end of the async.series as a finalizing function, but it seems it too gets called multiple times each time a previous function has called the callback.

@lakka
Copy link

lakka commented Jun 17, 2014

Tests pass, merging.

lakka pushed a commit that referenced this pull request Jun 17, 2014
@lakka lakka merged commit 580386f into master Jun 17, 2014
@kenkku kenkku deleted the sprint-4-system-blackbox-separate-gearslothds branch June 18, 2014 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants