Support OpenSSL encryption with compression (not instead of) #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus assorted minor improvements.
The main effect of this PR is that OpenSSL encryption is now applied on top of compression, whereas previously it was synonymous with no compression. I contemplated adding yet another command line option to work around this behavior change but then decided that in the end, compression is a Good Thing and if some users want to encrypt their archives without compressing they can use
--nocompoption explicitly instead of relying on a unintended side effect of previous implementation.That said, while I see this as a minor breaking change it is still a change. If you think it is a Bad Thing I'm open to working around this issue.