Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiqueue support #16

Merged
merged 2 commits into from
Apr 14, 2020
Merged

feat: add multiqueue support #16

merged 2 commits into from
Apr 14, 2020

Conversation

jibi
Copy link
Contributor

@jibi jibi commented Apr 11, 2020

This commit adds support for multiqueue interfaces.

Multiqueue devices are supported only on Linux, so trying to create a
device with more than one queue on OSX will return an
InvalidQueuesNumber error.

@jibi jibi mentioned this pull request Apr 11, 2020
Copy link
Owner

@meh meh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should also be stuff in async to support multi queues, shouldn't it?

src/platform/macos/device.rs Outdated Show resolved Hide resolved
@jibi jibi force-pushed the mq-support branch 3 times, most recently from d692321 to 1306f3c Compare April 11, 2020 23:07
This commit adds support for multiqueue interfaces.

Multiqueue devices are supported only on Linux, so trying to create a
device with more than one queue on OSX will return an
InvalidQueuesNumber error.
@meh
Copy link
Owner

meh commented Apr 13, 2020

Can you rename QueueAsync to AsyncQueue and DeviceAsync to AsyncDevice please?

@meh meh merged commit 894f450 into meh:master Apr 14, 2020
zonyitoo pushed a commit to zonyitoo/rust-tun that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants