feat: improving async and sync API #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabify
changed the title
|
This conceptually would resolve a lot of issues for me that currently require extensive work-arounds. |
|
Seems a clean solution and it'd be really helpful also in my case @sabify Do you know by chance if (and how) is possible to access the |
feifeigood
pushed a commit
to feifeigood/rust-tun
that referenced
this pull request
Jun 12, 2024
* update example * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * set tun name * add set_tun_name for freebsd * add set_tun_name for freebsd * unify the access of internal api * update freebsd * update example * cargo fmt * cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will remove the requirement for obtaining an unnecessary mutable reference to self in AsyncRead and AsyncWrite, as it is already protected by locks within the code. It will also include methods like
sendandrecvin the async API that can be used concurrently by only sharing a reference to the queue.The method
queuewill be replaced byqueue_mut, as it is intended to be. Additionally, two more methods will be added:queue, which returns a reference to the queue, andqueues, which transmute thedeviceto the vector of its queues.