Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m_glyphsTextRectCache random crash #470

Closed
2 of 5 tasks
patrykq112 opened this issue Mar 13, 2023 · 2 comments
Closed
2 of 5 tasks

m_glyphsTextRectCache random crash #470

patrykq112 opened this issue Mar 13, 2023 · 2 comments
Labels
Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@patrykq112
Copy link

Priority

Critical

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

Random crashes occur from time to time, related to "m_glyphsTextRectCache"
crash

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@patrykq112 patrykq112 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Mar 13, 2023
@github-actions github-actions bot added Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing labels Mar 13, 2023
@themaoci
Copy link
Contributor

its propably glyphsCords array that is out of bounds (simple check for that should fix that)

@mehah
Copy link
Owner

mehah commented Mar 14, 2023

@patrykq112
you didn't print the error.

@mehah mehah closed this as completed in 9a6725d Mar 15, 2023
dudantas added a commit that referenced this issue Nov 17, 2023
@dudantas
Fixed remove items from stash on create market offer and others things (
4e49d5b 
#474)

Resolves #470

• Created the Player::requestLockerItems function to avoid code repetition, it can be used in ProtocolGame and Game class improved the way locker items were read and stored
• Game::getMarketItemList function has been replaced by Player::requestLockerItems
• Small modification in ProtocolGame::sendMarketEnter function to avoid code repetition, it will read Player::requestLockerItems function

•Added some error logs for market functions so that we can identify where the problem was, in future tests. And if there is a problem during the processing of the offer, it will not be created, making it impossible to have an item or money clone.

• Added some logs (debug) to make it easier to find problems in the future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mehah @patrykq112 @themaoci