Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Highlight] Select top item of stack, instead them all #474

Closed
2 of 5 tasks
Riverlance opened this issue Mar 16, 2023 · 0 comments
Closed
2 of 5 tasks

[Highlight] Select top item of stack, instead them all #474

Riverlance opened this issue Mar 16, 2023 · 0 comments
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Riverlance
Copy link
Contributor

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

Explanation

On original Tibia, if items are one above another and your mouse is on its position, it will highlight only the item on top, not all of them.

Tibia

image

Mehah

image

Note: I tried this with the original code of 16th March 2023 with original TFS 1.5 and protocol 12.87.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Riverlance Riverlance added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Mar 16, 2023
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Mar 16, 2023
@Riverlance Riverlance changed the title Select top item of stack, instead them all [Highlight] Select top item of stack, instead them all Mar 16, 2023
@mehah mehah closed this as completed in 2e5d2b6 Mar 16, 2023
@Riverlance Riverlance mentioned this issue Aug 19, 2023
Closed
10 tasks
dudantas added a commit that referenced this issue Nov 17, 2023
@dudantas
Fixed remove items from stash on create market offer and others things (
4e49d5b 
#474)

Resolves #470

• Created the Player::requestLockerItems function to avoid code repetition, it can be used in ProtocolGame and Game class improved the way locker items were read and stored
• Game::getMarketItemList function has been replaced by Player::requestLockerItems
• Small modification in ProtocolGame::sendMarketEnter function to avoid code repetition, it will read Player::requestLockerItems function

•Added some error logs for market functions so that we can identify where the problem was, in future tests. And if there is a problem during the processing of the offer, it will not be created, making it impossible to have an item or money clone.

• Added some logs (debug) to make it easier to find problems in the future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Riverlance