Hide and deprecate AsyncConfigBuilder #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
matthiasbeyer
approved these changes
Oct 23, 2023
|
Your signoff is missing on the commits here, please add them. Otherwise this is a good catch, thank you for contributing! 🎉 |
|
gitlint will also complain here about long lines in the commit. Do you want me to take over to safe you the hassle? |
Does that mean I'm not to quote error messages in commit messages? That's a shame. Yes, please, do feel free to take this over. |
This struct seems to be a remnant of a previous approach to async. It cannot be used, and the documentation was lies. There isn't a `build` method. There are, in fact, no methods at all. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a nonfunctional vestige.