Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs warnings #481

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Fix docs warnings #481

merged 2 commits into from
Oct 23, 2023

Conversation

ijackson
Copy link
Contributor

Together with #480, this makes cargo doc --workspace clean.

(Perhaps there should be a CI test for this.)

@matthiasbeyer
Copy link
Collaborator

Your signoff is missing from the commits.

If you want, I'd welcome a PR for adding CI to test the docs!

Copy link
Collaborator

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging on green CI, thanks again for your contributions!

@matthiasbeyer
Copy link
Collaborator

Doh. gitlint doesn't like the extra long lines. If you want I can take over and clean this up for you, to save you the hassle?

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer merged commit 1887369 into mehcode:master Oct 23, 2023
15 checks passed
@ijackson ijackson deleted the warning branch October 23, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted PR for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants