v0.25 #1288

guimachiavelli · 2021-11-17T15:23:31Z

This is a hub PR for all v0.25-related updates.

Please, do not add any changes directly to it; instead, create a new branch based off this PR's branch.

netlify · 2021-11-17T15:23:38Z

✔️ Deploy Preview for distracted-wiles-3edfc5 ready!

🔨 Explore the source changes: f34d8da

🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-wiles-3edfc5/deploys/61dd77b67d31f40008a13c48

😎 Browse the preview: https://deploy-preview-1288--distracted-wiles-3edfc5.netlify.app

…es.md

-updated the code sample names -updated tasks.md -updated all links to the tasks.md file -updated config.js

- 202 Accepted instead of just updateId - updated indexes.md - partially updated tasks.md responses -replace udb with task_db

-use async operations

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

Remove comments, standardize 'masterKey' and 'apiKey' for authorization in examples

.code-samples.meilisearch.yaml

learn/advanced/updating.md

reference/features/security.md

bidoubiwa · 2022-01-07T12:28:37Z

Small feedback on the naming of the security guide. I was searching everywhere where the guide was on API keys. Couln't find it so I went through the API references to find the link to the guide.

It appears it is in security. A name like Permissions or authentication could have made it more clear that we have that feature. Security is more about your password needs to be at least 8 char long with different type of characters than showing of features.

.code-samples.meilisearch.yaml

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

guimachiavelli · 2022-01-10T13:20:29Z

Thanks for the feedback, @bidoubiwa. We changed the name of this guide based on @gmourier's remark from a few months ago. In essence, if I understood it correctly, what MeiliSearch does is more accurately called Authorization.

We decided to go for a generic Security title on this PR to avoid getting caught in discussions of which term is 100% accurate. Do you think Security and Permissions would be clearer?

gmourier · 2022-01-10T13:32:40Z

Thanks for the feedback, @bidoubiwa. We changed the name of this guide based on @gmourier's remark from a few months ago. In essence, if I understood it correctly, what MeiliSearch does is more accurately called Authorization.

We decided to go for a generic Security title on this PR to avoid getting caught in discussions of which term is 100% accurate. Do you think Security and Permissions would be clearer?

We could use the synonyms feature to allow the search bar to find the guide more easily. 🤓

E.g: Api Key, security, permissions, authentication, authorization, etc..

@guimachiavelli Security and Permissions is a good idea if you want my 2 cents 😇

1358: Revert docker command r=guimachiavelli a=curquiza I rollback the change I did in this PR #1329 Why? Here is the story - A [PR](meilisearch/meilisearch#1759) regarding the dockerfile was accepted, merged, and released in v0.24.0 - I realized, after the v0.24.0 release, this change in the dockerfile impacted the `data.ms` path: for the docker users, the default path was `/home/meili` and not `/` anymore. So, this change impacted the documentation command as well. - So I created this PR (#1329) to fix the v0.24.0 documentation - Some weeks later, we realized this dockerfile PR introduced a bug for the Linux users in v0.24.0 - Many spent a lot of time to fix this, but without any success - We decided to [rollback the PR](meilisearch/meilisearch#2032) and to come back to the initial behavior -> in v0.25.0, the data.ms will be in `/` and not in `/home/meili` anymore - So, I need to create the PR you see right now, for v0.25.0 😇 More information here: meilisearch/meilisearch#2051 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>

.code-samples.meilisearch.yaml

guimachiavelli · 2022-01-11T11:51:53Z

Ok, so based on feedback from @bidoubiwa and @gmourier we're changing the title of the new guide from "Security" to "Security and permissions."

.code-samples.meilisearch.yaml

Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>

dichotommy

LGTM! 🚀

guimachiavelli · 2022-01-11T15:36:11Z

bors merge

1288: v0.25 r=guimachiavelli a=guimachiavelli This is a hub PR for all v0.25-related updates. Please, do not add any changes directly to it; instead, create a new branch based off this PR's branch. Co-authored-by: gui machiavelli <hey@guimachiavelli.com> Co-authored-by: Maryam Sulemani <maryam@meilisearch.com> Co-authored-by: maryamsulemani97 <90181761+maryamsulemani97@users.noreply.github.com>

bors · 2022-01-11T15:37:35Z

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Gotta merge fast

guimachiavelli · 2022-01-11T15:46:56Z

thanks, @dichotommy 👍
now, bors, be a good bot

bors merge

bors · 2022-01-11T15:48:16Z

Build succeeded:

guimachiavelli added 2 commits October 21, 2021 18:53

reference/api/indexes: POST, PUT, and DELETE routes are now async

800e497

v0.25: version bump

540a6cc

guimachiavelli added this to the v0.25 milestone Nov 17, 2021

guimachiavelli changed the title ~~v0.25: version bump~~ v0.25 Nov 17, 2021

maryamsulemani97 and others added 25 commits November 18, 2021 13:57

replaced updateId with uid

59027c0

replaced an uid with a uid, updated links, updated asynchronous_updat…

ebb9f4a

…es.md

-renamed updates.md to tasks.md

747ee35

-updated the code sample names -updated tasks.md -updated all links to the tasks.md file -updated config.js

replaced update with task

2aa4717

- added new errors

7e7242f

- 202 Accepted instead of just updateId - updated indexes.md - partially updated tasks.md responses -replace udb with task_db

updated code samples for tasks.md

dbfb19c

updated 202 Accepted

8c71588

updated telemetry+json in asynchronous_updates.md

e31ca57

minor edits

0bb2b56

new updates

6aba771

-replace update with task

68072fb

-use async operations

add new errors

3f1e187

improve wording

afeeb7f

upate error message

af5dc14

updated telemetry page

9cd40f3

remove invalid_token error

e9a5c64

/reference/api/indexes: improve wording

6c17795

Update reference/features/dumps.md

7f4a22f

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

update based on review

9731764

updates based on review

9ff1c54

Update learn/advanced/asynchronous_operations.md

2f3b3f9

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

Update learn/advanced/asynchronous_operations.md

3f7050b

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

update based on review

386672a

Update reference/api/synonyms.md

ae218f6

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

Update reference/api/documents.md

2f87720

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

Update v0.25 code samples

de86bf9

Remove comments, standardize 'masterKey' and 'apiKey' for authorization in examples

dichotommy requested review from curquiza, dichotommy and bidoubiwa January 5, 2022 23:08

bidoubiwa previously requested changes Jan 6, 2022

View reviewed changes

curquiza reviewed Jan 10, 2022

View reviewed changes

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

Apply suggestions from code review

4f6c7f6

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

guimachiavelli and others added 2 commits January 10, 2022 14:39

Address review feedback

26ade0f

alallema reviewed Jan 11, 2022

View reviewed changes

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

Change title of new guide from Security to Security and Permissions

83eb230

Style guide 💅

1b803a0

guimachiavelli requested review from dichotommy and removed request for dichotommy January 11, 2022 11:52

dichotommy reviewed Jan 11, 2022

View reviewed changes

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

Apply suggestions from code review

f34d8da

Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>

dichotommy approved these changes Jan 11, 2022

View reviewed changes

bors bot merged commit 741fe26 into master Jan 11, 2022

bors bot deleted the v025 branch January 11, 2022 15:48

curquiza mentioned this pull request Jan 11, 2022

Add code samples for v0.25.0 meilisearch/meilisearch-ruby#286

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v0.25 #1288

v0.25 #1288

guimachiavelli commented Nov 17, 2021 •

edited

Loading

netlify bot commented Nov 17, 2021 •

edited

Loading

bidoubiwa commented Jan 7, 2022 •

edited

Loading

guimachiavelli commented Jan 10, 2022

gmourier commented Jan 10, 2022 •

edited

Loading

guimachiavelli commented Jan 11, 2022

dichotommy left a comment •

edited

Loading

guimachiavelli commented Jan 11, 2022

bors bot commented Jan 11, 2022

guimachiavelli commented Jan 11, 2022

bors bot commented Jan 11, 2022

v0.25 #1288

v0.25 #1288

Conversation

guimachiavelli commented Nov 17, 2021 • edited Loading

netlify bot commented Nov 17, 2021 • edited Loading

bidoubiwa commented Jan 7, 2022 • edited Loading

guimachiavelli commented Jan 10, 2022

gmourier commented Jan 10, 2022 • edited Loading

guimachiavelli commented Jan 11, 2022

dichotommy left a comment • edited Loading

Choose a reason for hiding this comment

guimachiavelli commented Jan 11, 2022

bors bot commented Jan 11, 2022

guimachiavelli commented Jan 11, 2022

bors bot commented Jan 11, 2022

guimachiavelli commented Nov 17, 2021 •

edited

Loading

netlify bot commented Nov 17, 2021 •

edited

Loading

bidoubiwa commented Jan 7, 2022 •

edited

Loading

gmourier commented Jan 10, 2022 •

edited

Loading

dichotommy left a comment •

edited

Loading