-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.25 #1288
Conversation
✔️ Deploy Preview for distracted-wiles-3edfc5 ready! 🔨 Explore the source changes: f34d8da 🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-wiles-3edfc5/deploys/61dd77b67d31f40008a13c48 😎 Browse the preview: https://deploy-preview-1288--distracted-wiles-3edfc5.netlify.app |
-updated the code sample names -updated tasks.md -updated all links to the tasks.md file -updated config.js
- 202 Accepted instead of just updateId - updated indexes.md - partially updated tasks.md responses -replace udb with task_db
-use async operations
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Remove comments, standardize 'masterKey' and 'apiKey' for authorization in examples
Small feedback on the naming of the It appears it is in |
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Thanks for the feedback, @bidoubiwa. We changed the name of this guide based on @gmourier's remark from a few months ago. In essence, if I understood it correctly, what MeiliSearch does is more accurately called Authorization. We decided to go for a generic Security title on this PR to avoid getting caught in discussions of which term is 100% accurate. Do you think Security and Permissions would be clearer? |
We could use the synonyms feature to allow the search bar to find the guide more easily. 🤓 E.g: Api Key, security, permissions, authentication, authorization, etc.. @guimachiavelli Security and Permissions is a good idea if you want my 2 cents 😇 |
1358: Revert docker command r=guimachiavelli a=curquiza I rollback the change I did in this PR #1329 Why? Here is the story - A [PR](meilisearch/meilisearch#1759) regarding the dockerfile was accepted, merged, and released in v0.24.0 - I realized, after the v0.24.0 release, this change in the dockerfile impacted the `data.ms` path: for the docker users, the default path was `/home/meili` and not `/` anymore. So, this change impacted the documentation command as well. - So I created this PR (#1329) to fix the v0.24.0 documentation - Some weeks later, we realized this dockerfile PR introduced a bug for the Linux users in v0.24.0 - Many spent a lot of time to fix this, but without any success - We decided to [rollback the PR](meilisearch/meilisearch#2032) and to come back to the initial behavior -> in v0.25.0, the data.ms will be in `/` and not in `/home/meili` anymore - So, I need to create the PR you see right now, for v0.25.0 😇 More information here: meilisearch/meilisearch#2051 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Ok, so based on feedback from @bidoubiwa and @gmourier we're changing the title of the new guide from "Security" to "Security and permissions." |
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
bors merge |
1288: v0.25 r=guimachiavelli a=guimachiavelli This is a hub PR for all v0.25-related updates. Please, do not add any changes directly to it; instead, create a new branch based off this PR's branch. Co-authored-by: gui machiavelli <hey@guimachiavelli.com> Co-authored-by: Maryam Sulemani <maryam@meilisearch.com> Co-authored-by: maryamsulemani97 <90181761+maryamsulemani97@users.noreply.github.com>
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
thanks, @dichotommy 👍 bors merge |
Build succeeded: |
This is a hub PR for all v0.25-related updates.
Please, do not add any changes directly to it; instead, create a new branch based off this PR's branch.