Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests related to the next Meilisearch release (v1.6.0) #368

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

meili-bot
Copy link
Contributor

@meili-bot meili-bot commented Dec 26, 2023

Related to this issue: meilisearch/integration-guides#294

This PR:

  • gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of Meilisearch.
  • might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

This PR is auto-generated for the pre-release week purpose.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7411ffb) 81.85% compared to head (fb8adad) 75.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   81.85%   75.83%   -6.03%     
==========================================
  Files          57       55       -2     
  Lines        1345     1320      -25     
==========================================
- Hits         1101     1001     -100     
- Misses        244      319      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Jan 11, 2024
@curquiza curquiza changed the title Changes related to the next Meilisearch release (v1.6.0) Update tests related to the next Meilisearch release (v1.6.0) Jan 15, 2024
@curquiza curquiza added maintenance Anything related to maintenance (CI, tests, refactoring...) and removed skip-changelog The PR will not appear in the release changelogs labels Jan 15, 2024
@curquiza curquiza marked this pull request as ready for review January 15, 2024 12:51
curquiza
curquiza previously approved these changes Jan 15, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

meili-bors bot added a commit that referenced this pull request Jan 15, 2024
368: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Copy link
Contributor

meili-bors bot commented Jan 15, 2024

Build failed:

@curquiza
Copy link
Member

@ahmednfwela do you know how to fix this linter issue? 😇

@ahmednfwela
Copy link
Collaborator

ahmednfwela commented Jan 15, 2024

@ahmednfwela
Copy link
Collaborator

What's weird is that locally there are no errors

@brunoocasali
Copy link
Member

My local environment is completely wrecked 🐙

image

@brunoocasali
Copy link
Member

I was running with dart 3.2.3, let's see with 3.2.4

@ahmednfwela
Copy link
Collaborator

I currently have Dart SDK version: 3.2.3 (stable) (Tue Dec 5 17:58:33 2023 +0000) on "windows_x64"

@brunoocasali
Copy link
Member

I didn't get the deps from tools, now I have the same as you @ahmednfwela no error locally...

@ahmednfwela
Copy link
Collaborator

Looking at the errors though, it seems it's restoring an older version of dart_jsonwebtoken 2.3.2 (2.12.2 available)
https://github.com/meilisearch/meilisearch-dart/actions/runs/7529114617/job/20492688294#step:4:28

but JWTException was introduced at 2.8.0 (I even commented there at the time for the same reason)

seems like we have to update all packages in pubspec.yaml to the latest minor version to fix this

@ahmednfwela
Copy link
Collaborator

All green now 👍

@curquiza
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Jan 16, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit ec68546 into main Jan 16, 2024
8 of 9 checks passed
@meili-bors meili-bors bot deleted the bump-meilisearch-v1.6.0 branch January 16, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants