Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to Meilisearch v1.6.0 #294

Closed
31 of 34 tasks
curquiza opened this issue Dec 18, 2023 · 11 comments
Closed
31 of 34 tasks

Changes related to Meilisearch v1.6.0 #294

curquiza opened this issue Dec 18, 2023 · 11 comments
Labels
Meilisearch bump Changes related to the Meilisearch bump version

Comments

@curquiza
Copy link
Member

curquiza commented Dec 18, 2023

This issue gathers the changes related to the v1.6.0 of Meilisearch that will impact the integrations scope.

📅 Release date: 15/01/2024

TODO

Before pre-release

  • Define (with the help of PMs) which integrations should be updated to include the new features in the latest version of Meilisaearch. Most of the time, it will be tier #1 integrations.
    Integration to update:
    • JS
    • PHP

Pre-release

  • With the help of this CI running on rc0, define in which SDKs we have to update the tests
  • Create a branch by running Octopus script: only open branches for the integrations we choose to update + Kubernetes repository + Cloud provider repository (changing the version) + SDKs/integrations where we must update the test suite.
  • Update integrations according to the new Meilisearch features (cf below which feature and how 👇)
    ⚠️ If possible, this step is done before pre-release, once the feature is ready thanks to the prototype released by the engine team
    • JS
    • PHP
  • Update integrations having failing test suites with the new RC of Meilisearch (refer to this CI)
    • JS
    • PHP
    • Python
    • Go
    • Dart
  • Add code samples for the chosen up-to-date integrations with the new version of Meilisearch
  • Update the library version of the related integrations and prepare the changelogs

Release day

  • ⚠️ for one of these SDKs (Dart, Python, Go) that don't have integrated the new vector search, create appropriate communication in issues and release notes!
  • Release the integrations
    • JS
    • PHP
  • Merge PR related to vector search communication for
    • Python
    • Go
    • Dart
  • Merge the related PR in K8s repository
  • Publish DevOps tools:
    • create the git tag
    • publish images (steps are in CONTRIBUTING.md)
  • Open issues in the repositories that are not up-to-date with the latest version of Meilisearch (including code samples)

Features to implement

proximityPrecision settings

Issue: meilisearch/meilisearch#4187
Usage: https://www.notion.so/meilisearch/Customize-proximity-precision-usage-aa69c2bab2c3402bab9340ae4def4577

Should be implemented for

  • JS
  • PHP

Vector search v2

Usage: https://www.notion.so/meilisearch/v1-6-Hybrid-Search-Embedders-ea42c82f90cc4bc0be1eeb917c1118c8

By Meili developers

  • JS
  • PHP

By community if available

  • Python
  • Go
  • Dart

-> ⚠️ If not implemented by community, we will have to be clear (release notes + issues) the experimental vector search feature is broken in the SDK until someone implements it.

@curquiza curquiza added the Meilisearch bump Changes related to the Meilisearch bump version label Dec 18, 2023
@sanders41
Copy link

(?) Python for vector search v2

I verified that at a minimum the python tests will need updating for vector search.

test_vector_search result:

meilisearch.errors.MeilisearchApiError: MeilisearchApiError. Error code: missing_search_hybrid. Error message: Invalid request: missing `hybrid` parameter when both `q` and `vector` are present.. Hint: It might not be working because you're not up to date with the Meilisearch version that search call requires. Error documentation: https://docs.meilisearch.com/errors#missing_search_hybrid Error type: invalid_request

meili-bors bot added a commit to meilisearch/meilisearch-python that referenced this issue Jan 15, 2024
900: Changes related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
meili-bors bot added a commit to meilisearch/meilisearch-go that referenced this issue Jan 15, 2024
503: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
meili-bors bot added a commit to meilisearch/meilisearch-dart that referenced this issue Jan 15, 2024
368: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
meili-bors bot added a commit to meilisearch/meilisearch-php that referenced this issue Jan 15, 2024
600: Changes related to the next Meilisearch release (v1.6.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
meili-bors bot added a commit to meilisearch/meilisearch-python that referenced this issue Jan 15, 2024
900: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
meili-bors bot added a commit to meilisearch/meilisearch-python that referenced this issue Jan 15, 2024
900: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
meili-bors bot added a commit to meilisearch/meilisearch-kubernetes that referenced this issue Jan 15, 2024
219: Changes related to the next Meilisearch release (v1.6.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#294

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: brunoocasali <brunoocasali@users.noreply.github.com>
meili-bors bot added a commit to meilisearch/meilisearch-js that referenced this issue Jan 15, 2024
1614: Changes related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Morgane Dubus <30866152+mdubus@users.noreply.github.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Co-authored-by: Morgane Dubus <morgane.d@meilisearch.com>
@curquiza
Copy link
Member Author

curquiza commented Jan 15, 2024

Issues opened for proximityPrecision

Are k8s and cloud providers released @brunoocasali?

Also missing this PR to be merged on the dart side. Having an issue with linter 😢

meili-bors bot added a commit to meilisearch/meilisearch-dart that referenced this issue Jan 16, 2024
368: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Co-authored-by: Ahmed Fwela <ahmednfwela@bdaya-dev.com>
@curquiza
Copy link
Member Author

Discussed with @brunoocasali, k8s and cloud providers are done

Closing this issue then

@abrahimzaman360
Copy link

is this error fixed now? I'm still getting this erro?

@sanders41
Copy link

is this error fixed now? I'm still getting this erro?

Which SDK are you using? Which version of Meiliesarch? What is the error message?

@HugoWen
Copy link

HugoWen commented Feb 28, 2024

is this error fixed now? I'm still getting this erro?

Which SDK are you using? Which version of Meiliesarch? What is the error message?

I've got the same error when I do vector search using python sdk 0.30.0 and the version of Meilisearch is 1.6.2:
meilisearch.errors.MeilisearchApiError: MeilisearchApiError. Error code: missing_search_hybrid. Error message: Invalid request: missing hybridparameter when bothqandvector are present.. Hint: It might not be working because you're not up to date with the Meilisearch version that search call requires. Error documentation: https://docs.meilisearch.com/errors#missing_search_hybrid Error type: invalid_request

@sanders41
Copy link

I've got the same error when I do vector search using python sdk 0.30.0 and the version of Meilisearch is 1.6.2

Did you include the hybrid parameter with your search?

@kauly
Copy link

kauly commented Mar 5, 2024

@sanders41 I'm following this tutorial and I'm get the same error and there is nothing about the error code in the docs.

https://blog.meilisearch.com/langchain-semantic-search-tutorial/

image

@sanders41
Copy link

@sanders41 I'm following this tutorial and I'm get the same error and there is nothing about the error code in the docs.

There were breaking changes to vector search in 1.6. I have not used LangChain and don't know much about it, but looking at the example provided it doesn't look like LangChain is compatible with Meilisearch 1.6+ vector search.

@Strift I'm not sure if LangChain needs to be updated, if the tutorial needs updating to mention it works with Meilisearch >=1.3 <1.6, or if it is possible somehow to make it work with Meilisearch 1.6+?

@kauly
Copy link

kauly commented Mar 5, 2024

I tried to add an embedder to my meilisearch instance but I got the error bellow. When we add an embedded to meili, it will generate vectors for all documents or only use to embedding queries?

  "message": "The `_vectors` field in the document with id: `\"0c297f065a8c46cab12857ca5999c371\"` is not an object. Was expecting an object with a key for each embedder with manually provided vectors, but instead got `[-0......."

@Strift
Copy link
Contributor

Strift commented Mar 5, 2024

Hello @kauly,

If you want to use LangChain, please use a previous Meilisearch version, like v1.5.

Our current LangChain integration is intended for v1.3, v1.4, and v1.5. @CaroFG is currently updating our LangChain integration. After this, we'll update the tutorial too. 🙏

Thanks @sanders41 for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meilisearch bump Changes related to the Meilisearch bump version
Projects
None yet
Development

No branches or pull requests

6 participants