Feature/Tenant Token #248
Merged
Feature/Tenant Token #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
feature/tenant-token
branch
from
3470974
to
1440cae
Compare
alallema
approved these changes
Mar 10, 2022
| /// <param name="expiresAt">Date to express how long the generated token will last. If null the token will last forever.</param> | ||
| /// <exception cref="MeilisearchTenantTokenApiKeyInvalid">When there is no <paramref name="apiKey"/> defined in the client or as argument.</exception> | ||
| /// <exception cref="MeilisearchTenantTokenExpired">When the sent <paramref name="expiresAt"/> param is in the past</exception> | ||
| /// <returns>Responds with the generated token.</returns> |
There was a problem hiding this comment.
Suggested change
| /// <returns>Responds with the generated token.</returns> | |
| /// <returns>Returns a generated tenant token.</returns> |
bidoubiwa
approved these changes
Mar 10, 2022
| /// <summary> | ||
| /// Generate a tenant token to be used during search. | ||
| /// </summary> | ||
| /// <param name="searchRules">Object with the rules to be inject in the search call.</param> |
There was a problem hiding this comment.
Suggested change
| /// <param name="searchRules">Object with the rules to be inject in the search call.</param> | |
| /// <param name="searchRules">Object with the rules applied in a search call.</param> |
|
@alallema and @bidoubiwa since GH will dismiss your reviews if I implement your suggestions here, I will submit a new PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the
generateTenantTokenfollowing the specification meilisearch/specifications#89