-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Tenant Token #248
Feature/Tenant Token #248
Conversation
3470974
to
1440cae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put a suggestion on a comment but as it is not essential so I approve! 🎉
/// <param name="expiresAt">Date to express how long the generated token will last. If null the token will last forever.</param> | ||
/// <exception cref="MeilisearchTenantTokenApiKeyInvalid">When there is no <paramref name="apiKey"/> defined in the client or as argument.</exception> | ||
/// <exception cref="MeilisearchTenantTokenExpired">When the sent <paramref name="expiresAt"/> param is in the past</exception> | ||
/// <returns>Responds with the generated token.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// <returns>Responds with the generated token.</returns> | |
/// <returns>Returns a generated tenant token.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥🔥
/// <summary> | ||
/// Generate a tenant token to be used during search. | ||
/// </summary> | ||
/// <param name="searchRules">Object with the rules to be inject in the search call.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// <param name="searchRules">Object with the rules to be inject in the search call.</param> | |
/// <param name="searchRules">Object with the rules applied in a search call.</param> |
@alallema and @bidoubiwa since GH will dismiss your reviews if I implement your suggestions here, I will submit a new PR :) |
Create the
generateTenantToken
following the specification meilisearch/specifications#89