Add method DeleteDocumentsByFilter for Meilisearch v1.2 #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
changed the base branch from
get-documents-by-filter
to
bump-meilisearch-v1.2.0
alallema
changed the base branch from
bump-meilisearch-v1.2.0
to
get-documents-by-filter
alallema
force-pushed
the
delete-documents-by-filter
branch
from
d1a71a0
to
cbbf7a8
Compare
alallema
changed the base branch from
get-documents-by-filter
to
bump-meilisearch-v1.2.0
brunoocasali
requested changes
May 25, 2023
| client: defaultClient, | ||
| filterToApply: []string{"book_id"}, | ||
| filterToDelete: "book_id = 123", | ||
| documentsPtr: []docTestBooks{ |
There was a problem hiding this comment.
These are auto-generated tests, I think it's for pointers.
Comment on lines
+541
to
+545
| } | ||
| if err := i.client.executeRequest(req); err != nil { | ||
| return nil, VersionErrorHintMessage(err, &req) | ||
| } | ||
| return resp, nil |
There was a problem hiding this comment.
Suggested change
| } | |
| if err := i.client.executeRequest(req); err != nil { | |
| return nil, VersionErrorHintMessage(err, &req) | |
| } | |
| return resp, nil | |
| } | |
| if err := i.client.executeRequest(req); err != nil { | |
| return nil, VersionErrorHintMessage(err, &req) | |
| } | |
| return resp, nil |
There was a problem hiding this comment.
I can change it but all the others are formatted the same way
meili-bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
441: Update version for the next release (v0.25.0) r=alallema a=meili-bot Release CHANGELOG: This version introduces features released on Meilisearch v1.2.0 🎉 Check out the changelog of [Meilisearch v1.2.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.2.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ### 🚀 Enhancements - Addition of the method `DeleteDocumentsByFilter`, this method takes an `interface{}` which allows you to send different types of filters (`string`, `[]string`, `[]interface{}{[]string{}}`, ...). The `filter` field works precisely like the `filter` field used on the search method. See [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics). #440 `@alallema`⚠️ You must configure the attributes you want to filter using the `Index.UpdateFilterableAttributes()`.⚠️ Remember to **update your Meilisearch server to v1.2.0 or newer before** adopting it. - Add the ability to add `Filter` in the `DocumentsQuery`. When a query with a `filter` is sent to `getDocuments`, it will filter the documents like the `search` method. See [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics). #439 `@alallema`⚠️ You must configure the attributes you want to filter using the `Index.UpdateFilterableAttributes()`.⚠️ Remember to **update your Meilisearch server to v1.2.0 or newer before** adopting it. Thanks again to `@alallema,` `@curquiza` ! 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the specification: meilisearch/specifications#236
Added method
DeleteDocumentsByFilter, this method takes aninterface{}which allows you to send different types of filters (string,[]string,[]interface{}{[]string{}}, ...)The
filterfield works precisely like thefilterfield used on thesearchmethod. See the docs on how to use filters.